Commit 17d184c
fix: add exception handling to hermes-utils.rb (#54411)
Summary:
While working on the React Native macOS upgrade, I ran into this error while fetching hermes during `pod install`
```
Fetching podspec for `hermes-engine` from `../react-native/sdks/hermes-engine/hermes-engine.podspec`
[!] Failed to load 'hermes-engine' podspec:
[!] Invalid `hermes-engine.podspec` file: SSL_connect returned=1 errno=0 peeraddr=52.41.8.25:443 state=error: certificate verify failed (unable to get certificate CRL).
# from /Users/sanajmi/Developer/react-native-macos/packages/react-native/sdks/hermes-engine/hermes-engine.podspec:26
```
It seemed this simply came from an exception in `nightly_tarball_url`, which would stop the process. This change adds a fallback so that `pod install` can continue.
bypass-github-export-checks
## Changelog:
[INTERNAL] [FIXED] - add exception handling to hermes-utils.rb
Pull Request resolved: #54411
Test Plan: CI should pass
Reviewed By: cipolleschi
Differential Revision: D86225597
Pulled By: sbuggay
fbshipit-source-id: 3988dd5fdf199b719b9946234f865b2a4de389f81 parent ef3a858 commit 17d184c
1 file changed
Lines changed: 14 additions & 10 deletions
Lines changed: 14 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
269 | 273 | | |
270 | 274 | | |
271 | 275 | | |
| |||
0 commit comments