RNTester / RCTReactNativeFactory remove unused new architecture flags and RCTArchConfiguratorProtocol (#57054)

Summary:
Pull Request resolved: #57054

## Changelog:
[iOS][Breaking]  RNTester / RCTReactNativeFactory remove unused new architecture flags and RCTArchConfiguratorProtocol

Values are already `true`/YES

```
      [[RCTRootViewFactoryConfiguration alloc] initWithBundleURLBlock:bundleUrlBlock
                                                       newArchEnabled:YES
                                                   turboModuleEnabled:YES
                                                    bridgelessEnabled:YES];
```

Reviewed By: cipolleschi

Differential Revision: D107305248

fbshipit-source-id: bd09d12cf1d22ec6bb435333c05004b73fce98c5

Author: christophpurrer

packages/react-native/Libraries/AppDelegate/RCTArchConfiguratorProtocol.h

@@ -8,7 +8,6 @@
 #import <React/RCTBridgeDelegate.h>
 #import <React/RCTConvert.h>
 #import <UIKit/UIKit.h>
-#import "RCTArchConfiguratorProtocol.h"
 #import "RCTDependencyProvider.h"
 #import "RCTJSRuntimeConfiguratorProtocol.h"
 #import "RCTRootViewFactory.h"
@@ -39,8 +38,7 @@ typedef NS_ENUM(NSInteger, RCTReleaseLevel) { Canary, Experimental, Stable };
     RCTTurboModuleManagerDelegate,
     RCTComponentViewFactoryComponentProvider,
 #endif
-    RCTJSRuntimeConfiguratorProtocol,
-    RCTArchConfiguratorProtocol>
+    RCTJSRuntimeConfiguratorProtocol>
 
 /// Return the bundle URL for the main bundle.
 - (NSURL *__nullable)bundleURL;

packages/react-native/Libraries/AppDelegate/RCTReactNativeFactory.h

@@ -132,28 +132,6 @@ - (JSRuntimeFactoryRef)createJSRuntimeFactory
   return [_delegate createJSRuntimeFactory];
 }
 
-#pragma mark - RCTArchConfiguratorProtocol
-
-- (BOOL)newArchEnabled
-{
-  return YES;
-}
-
-- (BOOL)fabricEnabled
-{
-  return YES;
-}
-
-- (BOOL)turboModuleEnabled
-{
-  return YES;
-}
-
-- (BOOL)bridgelessEnabled
-{
-  return YES;
-}
-
 #pragma mark - RCTTurboModuleManagerDelegate
 
 - (Class)getModuleClassFromName:(const char *)name

packages/react-native/Libraries/AppDelegate/RCTReactNativeFactory.mm

@@ -19,7 +19,6 @@
 
 #import "RCTAppDelegate.h"
 #import "RCTAppSetupUtils.h"
-#import "RCTArchConfiguratorProtocol.h"
 #import "RCTDefaultReactNativeFactoryDelegate.h"
 #import "RCTDependencyProvider.h"
 #import "RCTJSRuntimeConfiguratorProtocol.h"

packages/react-native/scripts/ios-prebuild/templates/React_RCTAppDelegate-umbrella.h

@@ -159,13 +159,6 @@ - (void)userNotificationCenter:(UNUserNotificationCenter *)center
 }
 #endif
 
-#pragma mark - New Arch Enabled settings
-
-- (BOOL)bridgelessEnabled
-{
-  return YES;
-}
-
 #pragma mark - RCTComponentViewFactoryComponentProvider
 
 #ifndef RN_DISABLE_OSS_PLUGIN_HEADER

packages/rn-tester/RNTester/AppDelegate.mm

@@ -2608,13 +2608,6 @@ protocol RCTAnimationDriver : public NSObject {
   public virtual void stopAnimation();
 }
 
-protocol RCTArchConfiguratorProtocol {
-  public virtual BOOL bridgelessEnabled();
-  public virtual BOOL fabricEnabled();
-  public virtual BOOL newArchEnabled();
-  public virtual BOOL turboModuleEnabled();
-}
-
 protocol RCTAutoInsetsProtocol {
   public @property (assign) BOOL automaticallyAdjustContentInsets;
   public @property (assign) UIEdgeInsets contentInset;
@@ -2985,7 +2978,7 @@ protocol RCTPullToRefreshViewViewProtocol : public NSObject {
   public virtual void setNativeRefreshing:(BOOL refreshing);
 }
 
-protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol, public RCTArchConfiguratorProtocol {
+protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol {
   public @property (strong) id<RCTDependencyProvider> dependencyProvider;
   public virtual NSDictionary<NSString*, Class<RCTComponentViewProtocol>>* thirdPartyFabricComponents();
   public virtual NSURL* _Nullable bundleURL();

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -2596,13 +2596,6 @@ protocol RCTAnimationDriver : public NSObject {
   public virtual void stopAnimation();
 }
 
-protocol RCTArchConfiguratorProtocol {
-  public virtual BOOL bridgelessEnabled();
-  public virtual BOOL fabricEnabled();
-  public virtual BOOL newArchEnabled();
-  public virtual BOOL turboModuleEnabled();
-}
-
 protocol RCTAutoInsetsProtocol {
   public @property (assign) BOOL automaticallyAdjustContentInsets;
   public @property (assign) UIEdgeInsets contentInset;
@@ -2972,7 +2965,7 @@ protocol RCTPullToRefreshViewViewProtocol : public NSObject {
   public virtual void setNativeRefreshing:(BOOL refreshing);
 }
 
-protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol, public RCTArchConfiguratorProtocol {
+protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol {
   public @property (strong) id<RCTDependencyProvider> dependencyProvider;
   public virtual NSDictionary<NSString*, Class<RCTComponentViewProtocol>>* thirdPartyFabricComponents();
   public virtual NSURL* _Nullable bundleURL();

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

@@ -2608,13 +2608,6 @@ protocol RCTAnimationDriver : public NSObject {
   public virtual void stopAnimation();
 }
 
-protocol RCTArchConfiguratorProtocol {
-  public virtual BOOL bridgelessEnabled();
-  public virtual BOOL fabricEnabled();
-  public virtual BOOL newArchEnabled();
-  public virtual BOOL turboModuleEnabled();
-}
-
 protocol RCTAutoInsetsProtocol {
   public @property (assign) BOOL automaticallyAdjustContentInsets;
   public @property (assign) UIEdgeInsets contentInset;
@@ -2985,7 +2978,7 @@ protocol RCTPullToRefreshViewViewProtocol : public NSObject {
   public virtual void setNativeRefreshing:(BOOL refreshing);
 }
 
-protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol, public RCTArchConfiguratorProtocol {
+protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol {
   public @property (strong) id<RCTDependencyProvider> dependencyProvider;
   public virtual NSDictionary<NSString*, Class<RCTComponentViewProtocol>>* thirdPartyFabricComponents();
   public virtual NSURL* _Nullable bundleURL();