Commit 31f215a
Fix blocking animating non-layout props through
Summary:
Pull Request resolved: #55340
This diff fixes edge-case with animating non-layout props through `commitUpdates` path.
The non-layout props are animated through the synchronous short-path, skipping yoga layout calculations. In `RCTMountingManager` the `propKeysManagerByAnimated` were set on updated props which are then checked for and blocked in the RCTViewComponentView's `updateProps` method (non-layout props might be applied through the layout path as we animate props in batch that may consists of both types of props).
## Changelog:
[iOS][Fixed] - Fixed edge-case with animating non-layout props through the `commitUpdates` path.
Reviewed By: zeyap, javache
Differential Revision: D91677971
fbshipit-source-id: 75bfc39190d4296ed57d8bbf9970e391461419d0commitUpdates after the View was synchronously animated (#55340)1 parent dd56bb0 commit 31f215a
1 file changed
Lines changed: 8 additions & 3 deletions
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
286 | 287 | | |
287 | 288 | | |
288 | 289 | | |
289 | | - | |
290 | 290 | | |
291 | 291 | | |
292 | 292 | | |
| |||
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
299 | 306 | | |
300 | 307 | | |
301 | 308 | | |
302 | 309 | | |
303 | 310 | | |
304 | | - | |
305 | | - | |
306 | 311 | | |
307 | 312 | | |
308 | 313 | | |
| |||
0 commit comments