Remove dead HostTargetController::installPerfIssuesBinding declaration

sammy-SC · facebook-github-bot · commit 35f4cf0503a7 · 2026-06-09T06:37:57.000-07:00
Summary:
`HostTargetController::installPerfIssuesBinding()` was declared in `jsinspector-modern/HostTarget.h` but had no definition anywhere and no callers. (`HostTargetController` is `final`, so the method is not an override.) A declared-but-never-defined non-virtual member cannot be invoked — any call would be a link error — so this is unreachable dead code. The unrelated, live `HostTarget::installPerfIssuesBinding` (a different class) is left intact.

Changelog: [Internal]

Differential Revision: D108012907
diff --git a/packages/react-native/ReactCommon/jsinspector-modern/HostTarget.h b/packages/react-native/ReactCommon/jsinspector-modern/HostTarget.h
@@ -252,13 +252,6 @@ class HostTargetController final {
 
   bool hasInstance() const;
 
-  /**
-   * [Experimental] Install a runtime binding subscribing to new Performance
-   * Issues, which we broadcast to the V2 Perf Monitor overlay via
-   * \ref HostTargetDelegate::unstable_onPerfIssueAdded.
-   */
-  void installPerfIssuesBinding();
-
   /**
    * Increments the target's pause overlay counter. The counter represents the
    * exact number of Agents that have (concurrently) requested the pause
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
@@ -10514,7 +10514,6 @@ class facebook::react::jsinspector_modern::HostTargetController {
   public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();
   public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();
   public void incrementPauseOverlayCounter();
-  public void installPerfIssuesBinding();
 }
 
 class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api
@@ -10162,7 +10162,6 @@ class facebook::react::jsinspector_modern::HostTargetController {
   public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();
   public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();
   public void incrementPauseOverlayCounter();
-  public void installPerfIssuesBinding();
 }
 
 class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
@@ -10367,7 +10367,6 @@ class facebook::react::jsinspector_modern::HostTargetController {
   public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();
   public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();
   public void incrementPauseOverlayCounter();
-  public void installPerfIssuesBinding();
 }
 
 class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
@@ -12408,7 +12408,6 @@ class facebook::react::jsinspector_modern::HostTargetController {
   public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();
   public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();
   public void incrementPauseOverlayCounter();
-  public void installPerfIssuesBinding();
 }
 
 class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
@@ -12118,7 +12118,6 @@ class facebook::react::jsinspector_modern::HostTargetController {
   public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();
   public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();
   public void incrementPauseOverlayCounter();
-  public void installPerfIssuesBinding();
 }
 
 class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
@@ -12271,7 +12271,6 @@ class facebook::react::jsinspector_modern::HostTargetController {
   public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();
   public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();
   public void incrementPauseOverlayCounter();
-  public void installPerfIssuesBinding();
 }
 
 class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
@@ -7569,7 +7569,6 @@ class facebook::react::jsinspector_modern::HostTargetController {
   public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();
   public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();
   public void incrementPauseOverlayCounter();
-  public void installPerfIssuesBinding();
 }
 
 class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api
@@ -7419,7 +7419,6 @@ class facebook::react::jsinspector_modern::HostTargetController {
   public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();
   public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();
   public void incrementPauseOverlayCounter();
-  public void installPerfIssuesBinding();
 }
 
 class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
@@ -7560,7 +7560,6 @@ class facebook::react::jsinspector_modern::HostTargetController {
   public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();
   public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();
   public void incrementPauseOverlayCounter();
-  public void installPerfIssuesBinding();
 }
 
 class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {

Original file line number	Diff line number	Diff line change
`@@ -10514,7 +10514,6 @@ class facebook::react::jsinspector_modern::HostTargetController {`
`10514`	`10514`	`public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();`
`10515`	`10515`	`public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();`
`10516`	`10516`	`public void incrementPauseOverlayCounter();`
`10517`		`- public void installPerfIssuesBinding();`
`10518`	`10517`	`}`
`10519`	`10518`
`10520`	`10519`	`class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {`
Original file line number	Diff line number	Diff line change
`@@ -10162,7 +10162,6 @@ class facebook::react::jsinspector_modern::HostTargetController {`
`10162`	`10162`	`public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();`
`10163`	`10163`	`public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();`
`10164`	`10164`	`public void incrementPauseOverlayCounter();`
`10165`		`- public void installPerfIssuesBinding();`
`10166`	`10165`	`}`
`10167`	`10166`
`10168`	`10167`	`class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {`
Original file line number	Diff line number	Diff line change
`@@ -10367,7 +10367,6 @@ class facebook::react::jsinspector_modern::HostTargetController {`
`10367`	`10367`	`public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();`
`10368`	`10368`	`public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();`
`10369`	`10369`	`public void incrementPauseOverlayCounter();`
`10370`		`- public void installPerfIssuesBinding();`
`10371`	`10370`	`}`
`10372`	`10371`
`10373`	`10372`	`class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {`
Original file line number	Diff line number	Diff line change
`@@ -12408,7 +12408,6 @@ class facebook::react::jsinspector_modern::HostTargetController {`
`12408`	`12408`	`public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();`
`12409`	`12409`	`public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();`
`12410`	`12410`	`public void incrementPauseOverlayCounter();`
`12411`		`- public void installPerfIssuesBinding();`
`12412`	`12411`	`}`
`12413`	`12412`
`12414`	`12413`	`class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {`
Original file line number	Diff line number	Diff line change
`@@ -12118,7 +12118,6 @@ class facebook::react::jsinspector_modern::HostTargetController {`
`12118`	`12118`	`public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();`
`12119`	`12119`	`public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();`
`12120`	`12120`	`public void incrementPauseOverlayCounter();`
`12121`		`- public void installPerfIssuesBinding();`
`12122`	`12121`	`}`
`12123`	`12122`
`12124`	`12123`	`class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {`
Original file line number	Diff line number	Diff line change
`@@ -12271,7 +12271,6 @@ class facebook::react::jsinspector_modern::HostTargetController {`
`12271`	`12271`	`public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();`
`12272`	`12272`	`public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();`
`12273`	`12273`	`public void incrementPauseOverlayCounter();`
`12274`		`- public void installPerfIssuesBinding();`
`12275`	`12274`	`}`
`12276`	`12275`
`12277`	`12276`	`class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {`
Original file line number	Diff line number	Diff line change
`@@ -7569,7 +7569,6 @@ class facebook::react::jsinspector_modern::HostTargetController {`
`7569`	`7569`	`public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();`
`7570`	`7570`	`public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();`
`7571`	`7571`	`public void incrementPauseOverlayCounter();`
`7572`		`- public void installPerfIssuesBinding();`
`7573`	`7572`	`}`
`7574`	`7573`
`7575`	`7574`	`class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {`
Original file line number	Diff line number	Diff line change
`@@ -7419,7 +7419,6 @@ class facebook::react::jsinspector_modern::HostTargetController {`
`7419`	`7419`	`public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();`
`7420`	`7420`	`public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();`
`7421`	`7421`	`public void incrementPauseOverlayCounter();`
`7422`		`- public void installPerfIssuesBinding();`
`7423`	`7422`	`}`
`7424`	`7423`
`7425`	`7424`	`class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {`
Original file line number	Diff line number	Diff line change
`@@ -7560,7 +7560,6 @@ class facebook::react::jsinspector_modern::HostTargetController {`
`7560`	`7560`	`public facebook::react::jsinspector_modern::HostTargetDelegate& getDelegate();`
`7561`	`7561`	`public facebook::react::jsinspector_modern::tracing::HostTracingProfile stopTracing();`
`7562`	`7562`	`public void incrementPauseOverlayCounter();`
`7563`		`- public void installPerfIssuesBinding();`
`7564`	`7563`	`}`
`7565`	`7564`
`7566`	`7565`	`class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook::react::jsinspector_modern::LoadNetworkResourceDelegate {`