Skip to content

Commit 3dd26f9

Browse files
robhoganmeta-codesync[bot]
authored andcommitted
Update dev dependency selfsigned to v4, fix Node >=v24.5 compatibility, restore CI
Summary: CI fails after attempting to update to Node v24 (latest LTS) because our `dev-middleware` dev-only dependency `selfsigned` uses a default key size incompatible with the version of OpenSSL in Node>=24.5. We see lots of: ``` error:0A00018F:SSL routines::ee key too small ``` This was mitigated in OSS CI by pinning our Node tests to before v24.5: #53013 This default is raised upstream in jfromaniello/selfsigned@bf687c8 , this bumps to v4 which includes that fix, and removes the temporary mitigation above. Changelog: [Internal] Differential Revision: D87643898
1 parent 33f783a commit 3dd26f9

3 files changed

Lines changed: 6 additions & 14 deletions

File tree

.github/workflows/test-all.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ jobs:
479479
strategy:
480480
fail-fast: false
481481
matrix:
482-
node-version: ["24.4.1", "22", "20.19.4"]
482+
node-version: ["24", "22", "20.19.4"]
483483
steps:
484484
- name: Checkout
485485
uses: actions/checkout@v4

packages/dev-middleware/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
},
4141
"devDependencies": {
4242
"@react-native/debugger-shell": "0.84.0-main",
43-
"selfsigned": "^2.4.1",
43+
"selfsigned": "^4.0.0",
4444
"undici": "^5.29.0",
4545
"wait-for-expect": "^3.0.2"
4646
}

yarn.lock

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2334,13 +2334,6 @@
23342334
resolved "https://registry.yarnpkg.com/@types/ms/-/ms-2.1.0.tgz#052aa67a48eccc4309d7f0191b7e41434b90bb78"
23352335
integrity sha512-GsCCIZDE/p3i96vtEqx+7dBUGXrc7zeSK3wwPHIaRThS+9OhWIXRqzs4d6k1SVU8g91DrNRWxWUGhp5KXQb2VA==
23362336

2337-
"@types/node-forge@^1.3.0":
2338-
version "1.3.11"
2339-
resolved "https://registry.yarnpkg.com/@types/node-forge/-/node-forge-1.3.11.tgz#0972ea538ddb0f4d9c2fa0ec5db5724773a604da"
2340-
integrity sha512-FQx220y22OKNTqaByeBGqHWYz4cl94tpcxeFdvBo3wjG6XPBuZ0BNgNZRV5J5TFmmcsJ4IzsLkmGRiQbnYsBEQ==
2341-
dependencies:
2342-
"@types/node" "*"
2343-
23442337
"@types/node@*", "@types/node@^22.7.7":
23452338
version "22.15.18"
23462339
resolved "https://registry.yarnpkg.com/@types/node/-/node-22.15.18.tgz#2f8240f7e932f571c2d45f555ba0b6c3f7a75963"
@@ -8275,12 +8268,11 @@ scheduler@0.27.0, scheduler@^0.27.0:
82758268
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.27.0.tgz#0c4ef82d67d1e5c1e359e8fc76d3a87f045fe5bd"
82768269
integrity sha512-eNv+WrVbKu1f3vbYJT/xtiF5syA5HPIMtf9IgY/nKg0sWqzAUEvqY/xm7OcZc/qafLx/iO9FgOmeSAp4v5ti/Q==
82778270

8278-
selfsigned@^2.4.1:
8279-
version "2.4.1"
8280-
resolved "https://registry.yarnpkg.com/selfsigned/-/selfsigned-2.4.1.tgz#560d90565442a3ed35b674034cec4e95dceb4ae0"
8281-
integrity sha512-th5B4L2U+eGLq1TVh7zNRGBapioSORUeymIydxgFpwww9d2qyKvtuPU2jJuHvYAwwqi2Y596QBL3eEqcPEYL8Q==
8271+
selfsigned@^4.0.0:
8272+
version "4.0.0"
8273+
resolved "https://registry.yarnpkg.com/selfsigned/-/selfsigned-4.0.0.tgz#5b0518735f82fa8eb59b425bc92e29d29e5279f8"
8274+
integrity sha512-eP/1BEUCziBF/7p96ergE2JlGOMsGj9kIe77pD99G3ValgxDFwHA2oNCYW4rjlmYp8LXc684ypH0836GjSKw0A==
82828275
dependencies:
8283-
"@types/node-forge" "^1.3.0"
82848276
node-forge "^1"
82858277

82868278
semver-compare@^1.0.0:

0 commit comments

Comments
 (0)