fix: validate PerformanceObserver observe options

Author: ya-nsh

packages/react-native/src/private/webapis/performance/PerformanceObserver.js

@@ -203,18 +203,36 @@ export class PerformanceObserver {
     return observerHandle;
   }
 
-  #validateObserveOptions(options: PerformanceObserverInit): void {
-    const {type, entryTypes, durationThreshold} = options;
+  #validateObserveOptions(options: ?PerformanceObserverInit): void {
+    if (options == null) {
+      throw new TypeError(
+        "Failed to execute 'observe' on 'PerformanceObserver': 1 argument required, but only 0 present.",
+      );
+    }
+
+    const {type, entryTypes, durationThreshold, buffered} = options;
 
     if (!type && !entryTypes) {
       throw new TypeError(
-        "Failed to execute 'observe' on 'PerformanceObserver': An observe() call must not include both entryTypes and type arguments.",
+        "Failed to execute 'observe' on 'PerformanceObserver': An observe() call must include either entryTypes or type arguments.",
       );
     }
 
     if (entryTypes && type) {
       throw new TypeError(
-        "Failed to execute 'observe' on 'PerformanceObserver': An observe() call must include either entryTypes or type arguments.",
+        "Failed to execute 'observe' on 'PerformanceObserver': An observe() call must not include both entryTypes and type arguments.",
+      );
+    }
+
+    if (entryTypes && entryTypes.length === 0) {
+      throw new TypeError(
+        "Failed to execute 'observe' on 'PerformanceObserver': The entryTypes sequence must not be empty.",
+      );
+    }
+
+    if (entryTypes && buffered != null) {
+      throw new TypeError(
+        "Failed to execute 'observe' on 'PerformanceObserver': An observe() call must not include both entryTypes and buffered arguments.",
       );
     }
 

packages/react-native/src/private/webapis/performance/__tests__/PerformanceObserver-itest.js

@@ -96,6 +96,34 @@ describe('PerformanceObserver', () => {
     expect(entries2.getEntries()[1]).toBe(measure);
   });
 
+  describe('observe()', () => {
+    it('rejects invalid entry type option combinations before registering with native', () => {
+      const callback = jest.fn();
+      const observer = new PerformanceObserver(callback);
+
+      // $FlowExpectedError[incompatible-call]
+      expect(() => observer.observe()).toThrow(
+        "Failed to execute 'observe' on 'PerformanceObserver': 1 argument required, but only 0 present.",
+      );
+      expect(() => observer.observe({})).toThrow(
+        "Failed to execute 'observe' on 'PerformanceObserver': An observe() call must include either entryTypes or type arguments.",
+      );
+      expect(() =>
+        observer.observe({entryTypes: ['mark'], type: 'measure'}),
+      ).toThrow(
+        "Failed to execute 'observe' on 'PerformanceObserver': An observe() call must not include both entryTypes and type arguments.",
+      );
+      expect(() => observer.observe({entryTypes: []})).toThrow(
+        "Failed to execute 'observe' on 'PerformanceObserver': The entryTypes sequence must not be empty.",
+      );
+      expect(() =>
+        observer.observe({entryTypes: ['mark'], buffered: true}),
+      ).toThrow(
+        "Failed to execute 'observe' on 'PerformanceObserver': An observe() call must not include both entryTypes and buffered arguments.",
+      );
+    });
+  });
+
   describe('takeRecords()', () => {
     it('provides all buffered events and clears the buffer', () => {
       const callback = jest.fn();