Skip to content

Commit 40c90ad

Browse files
hurali97meta-codesync[bot]
authored andcommitted
fix: allow escape interpretation for shells (#57114)
Summary: This makes the shell to use escape interpretation by setting `echo -e "..."`. For zsh shell, this often works out of the box. For other shells like bash, we may need to set it explicitly. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [INTERNAL] [FIXED] - allow escape interpretation for shells Pull Request resolved: #57114 Test Plan: - CI Passes - Verified Locally on template app https://github.com/user-attachments/assets/4c8c6bf7-1cf2-4bd8-b094-651c44578ae0 Reviewed By: cipolleschi Differential Revision: D107904889 Pulled By: cortinico fbshipit-source-id: 2222f589ecc149a82d5067e0a2198b9c1a17ffcb
1 parent 8bcfb3b commit 40c90ad

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/e2e-android-templateapp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666
6767
echo "Feed maven local to gradle.properties"
6868
cd /tmp/RNTestProject
69-
echo "\nreact.internal.mavenLocalRepo=$MAVEN_LOCAL" >> android/gradle.properties
69+
echo -e "\nreact.internal.mavenLocalRepo=$MAVEN_LOCAL" >> android/gradle.properties
7070
7171
# Build
7272
cd android

scripts/release-testing/test-release-local.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ async function testRNTestProject(
292292

293293
// need to do this here so that Android will be properly setup either way
294294
exec(
295-
`echo "\nreact.internal.mavenLocalRepo=${mavenLocalPath}" >> android/gradle.properties`,
295+
`echo -e "\nreact.internal.mavenLocalRepo=${mavenLocalPath}" >> android/gradle.properties`,
296296
);
297297

298298
// Only build the simulator architecture. CI is however generating only that one.

0 commit comments

Comments
 (0)