Cleanup bundle loading logic (#54403)

Summary:
Pull Request resolved: #54403

Small tweaks to correct atomicity, set the thread name, and avoid a cop of the loaded bundle.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D85144130

fbshipit-source-id: a7ecdf5d33b5f30a62e00c4e5ac9fcfa93a056a2

Author: javache

packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.cpp

@@ -9,6 +9,7 @@
 
 #include <ReactCommon/TurboModuleBinding.h>
 #include <cxxreact/JSBigString.h>
+#include <folly/system/ThreadName.h>
 #include <glog/logging.h>
 #include <jserrorhandler/JsErrorHandler.h>
 #include <jsinspector-modern/InspectorFlags.h>
@@ -401,11 +402,13 @@ void ReactHost::destroyReactInstance() {
 }
 
 void ReactHost::reloadReactInstance() {
-  if (isReloadingReactInstance_) {
+  if (isReloadingReactInstance_.exchange(true)) {
     return;
   }
-  isReloadingReactInstance_ = true;
+
   std::thread([this]() {
+    folly::setThreadName("ReactReload");
+
     std::vector<SurfaceManager::SurfaceProps> surfaceProps;
     for (auto& surfaceId : surfaceManager_->getRunningSurfaces()) {
       if (auto surfaceProp = surfaceManager_->getSurfaceProps(surfaceId);
@@ -469,9 +472,8 @@ bool ReactHost::loadScriptFromDevServer() {
                   }
                 })
             .get();
-    auto script = std::make_unique<JSBigStdString>(response);
-    reactInstance_->loadScript(
-        std::move(script), devServerHelper_->getBundleUrl());
+    auto script = std::make_unique<JSBigStdString>(std::move(response));
+    reactInstance_->loadScript(std::move(script), bundleUrl);
     devServerHelper_->setupHMRClient();
     return true;
   } catch (...) {
@@ -486,6 +488,7 @@ bool ReactHost::loadScriptFromDevServer() {
 bool ReactHost::loadScriptFromBundlePath(const std::string& bundlePath) {
   try {
     LOG(INFO) << "Loading JS bundle from bundle path: " << bundlePath;
+    // TODO: use platform-native asset loading strategy
     auto script = std::make_unique<JSBigStdString>(
         ResourceLoader::getFileContents(bundlePath));
     reactInstance_->loadScript(std::move(script), bundlePath);

packages/react-native/ReactCxxPlatform/react/threading/TaskDispatchThread.cpp

@@ -22,9 +22,9 @@
 namespace facebook::react {
 
 TaskDispatchThread::TaskDispatchThread(
-    std::string threadName,
+    std::string_view threadName,
     int priorityOffset) noexcept
-    : threadName_(std::move(threadName)) {
+    : threadName_(threadName) {
 #ifdef ANDROID
   // Attaches the thread to JVM just in case anything calls out to Java
   thread_ = std::thread([&]() {

packages/react-native/ReactCxxPlatform/react/threading/TaskDispatchThread.h

@@ -26,7 +26,7 @@ class TaskDispatchThread {
   using TaskFn = std::function<void()>;
   using TimePoint = std::chrono::time_point<std::chrono::system_clock>;
 
-  TaskDispatchThread(std::string threadName = "", int priorityOffset = 0) noexcept;
+  TaskDispatchThread(std::string_view threadName = "", int priorityOffset = 0) noexcept;
 
   ~TaskDispatchThread() noexcept;