Hoist PerformanceLogger primitives out of react-native

Summary:
Changelog: [General][Fixed] Removed second argument for hook function passed to `AppRegistry.setComponentProviderInstrumentationHook` as it's not usable by apps.

## Context

The performance-logger primitives (`createPerformanceLogger`, `GlobalPerformanceLogger`, `IPerformanceLogger`, `PerformanceLoggerContext`) and the telemetry that lived inside the `react-native` package have always been Meta-internal. They were never exported from `index.js.flow` or `package.json#exports`, and the timespans/extras they emitted (`renderApplication_React_render`, `initializeCore_start`/`_end`, the `'GlobalPerformanceLogger'` callable native module, the per-app scoped `IPerformanceLogger`) only ever fed Meta's instrumentation.

Keeping them inside `react-native` adds dead weight to the OSS package and forces any future change to that surface to land through OSS sync. Hoisting them out keeps the OSS package focused on what external consumers actually use, while leaving Meta's instrumentation stack fully functional. This is non-breaking for OSS consumers — nothing that was importable from `react-native` becomes unavailable.

Technically, this could be considered a breaking change, because `AppRegistry.setComponentProviderInstrumentationHook` accepts a function that was receiving a performance logger as the second parameter, but because that performance logger wasn't later accessible anywhere, we should consider that it wasn't really used.

A quick search on Github yielded not results for the use of the API altogether: https://github.com/search?q=AppRegistry.setComponentProviderInstrumentationHook%28&type=code

## Changes

- Removed the perf-logger source files and their telemetry emission from `react-native`.
- `XMLHttpRequest` keeps its `setPerformanceLogger(...)` extension and the `network_XMLHttpRequest_<friendlyName>` start/stop timespan, but the parameter is now typed against a tiny local interface (`startTimespan(key)` / `stopTimespan(key)`) defined inside the module, so the file no longer depends on the moved primitives. The logger defaults to `null` (no global fallback); when no logger is set the timespan is not emitted. The unused `_startTime` field is dropped, and the XHR test for the custom-logger path is preserved with a hand-rolled spy.
- `InitializeCore.js` no longer emits `initializeCore_start` / `initializeCore_end` markPoints, and `setUpBatchedBridge.js` no longer registers the `'GlobalPerformanceLogger'` callable native module.
- `renderApplication.js` no longer wraps the rendered tree in `<PerformanceLoggerContext.Provider>`, no longer emits the `renderApplication_React_render` timespan, and no longer sets the `usedReactConcurrentRoot` / `usedReactFabric` / `usedReactProfiler` extras. Its previous 7th positional `scopedPerformanceLogger` parameter is preserved as a reserved `_unused?: void` slot so direct callers that still supply an extra value continue to type-check; the value is ignored.
- `AppRegistry.setComponentProviderInstrumentationHook` is preserved as part of the public API. The hook's previous second argument (the per-app `IPerformanceLogger`) is removed entirely; the hook signature is now `(component: ComponentProvider) => React.ComponentType<any>`. Embedders that need richer per-app context can attach it via their own mechanism.
- `ReactNativeApi.d.ts` is regenerated by `yarn build-types`. The generated public surface is identical except that `IPerformanceLogger` is gone and `ComponentProviderInstrumentationHook` no longer takes a second argument.

Differential Revision: D102166537

Author: rubennorte

packages/react-native/Libraries/Core/InitializeCore.js

@@ -26,17 +26,4 @@
 
 'use strict';
 
-const start = Date.now();
-
 require('../../src/private/setup/setUpDefaultReactNativeEnvironment').default();
-
-const GlobalPerformanceLogger =
-  require('../Utilities/GlobalPerformanceLogger').default;
-// We could just call GlobalPerformanceLogger.markPoint at the top of the file,
-// but then we'd be excluding the time it took to require the logger.
-// Instead, we just use Date.now and backdate the timestamp.
-GlobalPerformanceLogger.markPoint(
-  'initializeCore_start',
-  GlobalPerformanceLogger.currentTimestamp() - (Date.now() - start),
-);
-GlobalPerformanceLogger.markPoint('initializeCore_end');

packages/react-native/Libraries/Core/setUpBatchedBridge.js

@@ -25,10 +25,6 @@ registerModule(
   'RCTNativeAppEventEmitter',
   () => require('../EventEmitter/RCTNativeAppEventEmitter').default,
 );
-registerModule(
-  'GlobalPerformanceLogger',
-  () => require('../Utilities/GlobalPerformanceLogger').default,
-);
 
 if (__DEV__) {
   registerModule('HMRClient', () => require('../Utilities/HMRClient').default);

packages/react-native/Libraries/Network/XMLHttpRequest.js

@@ -14,7 +14,6 @@ import type {
   EventCallback,
   EventListener,
 } from '../../src/private/webapis/dom/events/EventTarget';
-import type {IPerformanceLogger} from '../Utilities/createPerformanceLogger';
 
 import Event from '../../src/private/webapis/dom/events/Event';
 import {
@@ -27,8 +26,6 @@ import ProgressEvent from '../../src/private/webapis/xhr/events/ProgressEvent';
 import {type EventSubscription} from '../vendor/emitter/EventEmitter';
 
 const BlobManager = require('../Blob/BlobManager').default;
-const GlobalPerformanceLogger =
-  require('../Utilities/GlobalPerformanceLogger').default;
 const RCTNetworking = require('./RCTNetworking').default;
 const base64 = require('base64-js');
 const invariant = require('invariant');
@@ -58,6 +55,17 @@ type XHRInterceptor = interface {
   loadingFailed(id: number, error: string): void,
 };
 
+/**
+ * Minimal contract for the optional performance logger that callers may attach
+ * via `setPerformanceLogger(...)`. Defined locally so this module stays
+ * self-contained and does not depend on any specific logger implementation.
+ * Any object satisfying these two methods structurally is accepted.
+ */
+type XHRPerformanceLogger = interface {
+  startTimespan(key: string): void,
+  stopTimespan(key: string): void,
+};
+
 // The native blob module is optional so inject it here if available.
 if (BlobManager.isAvailable) {
   BlobManager.addNetworkingHandler();
@@ -167,8 +175,7 @@ class XMLHttpRequest extends EventTarget {
   _timedOut: boolean = false;
   _trackingName: ?string;
   _incrementalEvents: boolean = false;
-  _startTime: ?number = null;
-  _performanceLogger: IPerformanceLogger = GlobalPerformanceLogger;
+  _performanceLogger: ?XHRPerformanceLogger = null;
 
   static __setInterceptor_DO_NOT_USE(interceptor: ?XHRInterceptor) {
     XMLHttpRequest._interceptor = interceptor;
@@ -334,8 +341,10 @@ class XMLHttpRequest extends EventTarget {
     responseURL: ?string,
   ): void {
     if (requestId === this._requestId) {
-      this._perfKey != null &&
-        this._performanceLogger.stopTimespan(this._perfKey);
+      const performanceLogger = this._performanceLogger;
+      if (this._perfKey != null && performanceLogger != null) {
+        performanceLogger.stopTimespan(this._perfKey);
+      }
       this.status = status;
       this.setResponseHeaders(responseHeaders);
       this.setReadyState(this.HEADERS_RECEIVED);
@@ -521,9 +530,15 @@ class XMLHttpRequest extends EventTarget {
   }
 
   /**
-   * Custom extension for setting a custom performance logger
+   * Custom extension that lets callers attach a performance logger receiving
+   * a `network_XMLHttpRequest_<friendlyName>` start/stop timespan around each
+   * dispatched request. The logger only needs to implement
+   * `startTimespan(key)` / `stopTimespan(key)` (see the `XHRPerformanceLogger`
+   * interface above). When no logger is set the timespan is not emitted.
    */
-  setPerformanceLogger(performanceLogger: IPerformanceLogger): XMLHttpRequest {
+  setPerformanceLogger(
+    performanceLogger: XHRPerformanceLogger,
+  ): XMLHttpRequest {
     this._performanceLogger = performanceLogger;
     return this;
   }
@@ -598,9 +613,11 @@ class XMLHttpRequest extends EventTarget {
 
     const doSend = () => {
       const friendlyName = this._trackingName ?? this._url;
-      this._perfKey = 'network_XMLHttpRequest_' + String(friendlyName);
-      this._performanceLogger.startTimespan(this._perfKey);
-      this._startTime = performance.now();
+      const performanceLogger = this._performanceLogger;
+      if (performanceLogger != null) {
+        this._perfKey = 'network_XMLHttpRequest_' + String(friendlyName);
+        performanceLogger.startTimespan(this._perfKey);
+      }
       invariant(
         this._method,
         'XMLHttpRequest method needs to be defined (%s).',

packages/react-native/Libraries/Network/__tests__/XMLHttpRequest-test.js

@@ -10,15 +10,10 @@
 
 'use strict';
 
-const createPerformanceLogger =
-  require('../../Utilities/createPerformanceLogger').default;
-const GlobalPerformanceLogger =
-  require('../../Utilities/GlobalPerformanceLogger').default;
 const Platform = require('../../Utilities/Platform').default;
 const XMLHttpRequest = require('../XMLHttpRequest').default;
 
 jest.unmock('../../Utilities/Platform');
-jest.mock('../../Utilities/GlobalPerformanceLogger');
 let requestId = 1;
 function setRequestId(id: number) {
   if (Platform.OS === 'ios') {
@@ -246,30 +241,11 @@ describe('XMLHttpRequest', function () {
     );
   });
 
-  it('should log to GlobalPerformanceLogger if a custom performance logger is not set', () => {
-    xhr.open('GET', 'blabla');
-    xhr.send();
-
-    expect(GlobalPerformanceLogger.startTimespan).toHaveBeenCalledWith(
-      'network_XMLHttpRequest_blabla',
-    );
-    expect(GlobalPerformanceLogger.stopTimespan).not.toHaveBeenCalled();
-
-    setRequestId(8);
-    xhr.__didReceiveResponse(requestId, 200, {
-      'Content-Type': 'text/plain; charset=utf-8',
-      'Content-Length': '32',
-    });
-
-    expect(GlobalPerformanceLogger.stopTimespan).toHaveBeenCalledWith(
-      'network_XMLHttpRequest_blabla',
-    );
-  });
-
   it('should log to a custom performance logger if set', () => {
-    const performanceLogger = createPerformanceLogger();
-    jest.spyOn(performanceLogger, 'startTimespan');
-    jest.spyOn(performanceLogger, 'stopTimespan');
+    const performanceLogger = {
+      startTimespan: jest.fn(),
+      stopTimespan: jest.fn(),
+    };
 
     xhr.setPerformanceLogger(performanceLogger);
 
@@ -279,7 +255,6 @@ describe('XMLHttpRequest', function () {
     expect(performanceLogger.startTimespan).toHaveBeenCalledWith(
       'network_XMLHttpRequest_blabla',
     );
-    expect(GlobalPerformanceLogger.startTimespan).not.toHaveBeenCalled();
     expect(performanceLogger.stopTimespan).not.toHaveBeenCalled();
 
     setRequestId(9);
@@ -291,7 +266,6 @@ describe('XMLHttpRequest', function () {
     expect(performanceLogger.stopTimespan).toHaveBeenCalledWith(
       'network_XMLHttpRequest_blabla',
     );
-    expect(GlobalPerformanceLogger.stopTimespan).not.toHaveBeenCalled();
   });
 
   it('should sort and lowercase response headers', function () {

packages/react-native/Libraries/ReactNative/AppRegistry.d.ts

@@ -8,7 +8,6 @@
  */
 
 import type * as React from 'react';
-import type {IPerformanceLogger} from '../Utilities/IPerformanceLogger';
 import type {ViewStyle} from '../StyleSheet/StyleSheetTypes';
 
 type Task = (taskData: any) => Promise<void>;
@@ -28,7 +27,6 @@ export type AppConfig = {
 
 export type ComponentProviderInstrumentationHook = (
   component: ComponentProvider,
-  scopedPerformanceLogger: IPerformanceLogger,
 ) => React.ComponentType<any>;
 
 export type WrapperComponentProvider = (

packages/react-native/Libraries/ReactNative/AppRegistry.flow.js

@@ -10,7 +10,6 @@
 
 import type {ViewStyleProp} from '../StyleSheet/StyleSheet';
 import type {RootTag} from '../Types/RootTagTypes';
-import type {IPerformanceLogger} from '../Utilities/createPerformanceLogger';
 import type {DisplayModeType} from './DisplayMode';
 
 type HeadlessTask = (taskData: any) => Promise<void>;
@@ -19,7 +18,6 @@ export type TaskProvider = () => HeadlessTask;
 export type ComponentProvider = () => React.ComponentType<any>;
 export type ComponentProviderInstrumentationHook = (
   component_: ComponentProvider,
-  scopedPerformanceLogger: IPerformanceLogger,
 ) => React.ComponentType<any>;
 export type AppConfig = {
   appKey: string,

packages/react-native/Libraries/ReactNative/AppRegistryImpl.js

@@ -22,7 +22,6 @@ import type {
   WrapperComponentProvider,
 } from './AppRegistry.flow';
 
-import createPerformanceLogger from '../Utilities/createPerformanceLogger';
 import SceneTracker from '../Utilities/SceneTracker';
 import {coerceDisplayMode} from './DisplayMode';
 import HeadlessJsTaskError from './HeadlessJsTaskError';
@@ -81,20 +80,16 @@ export function registerComponent(
   componentProvider: ComponentProvider,
   section?: boolean,
 ): string {
-  const scopedPerformanceLogger = createPerformanceLogger();
   runnables[appKey] = (appParameters, displayMode) => {
     const renderApplication = require('./renderApplication').default;
     renderApplication(
-      componentProviderInstrumentationHook(
-        componentProvider,
-        scopedPerformanceLogger,
-      ),
+      componentProviderInstrumentationHook(componentProvider),
       appParameters.initialProps,
       appParameters.rootTag,
       wrapperComponentProvider && wrapperComponentProvider(appParameters),
       rootViewStyleProvider && rootViewStyleProvider(appParameters),
       true, // fabric - deprecated, always true
-      scopedPerformanceLogger,
+      undefined, // formerly scopedPerformanceLogger; reserved positional slot
       appKey === 'LogBox', // is logbox
       appKey,
       displayMode,

packages/react-native/Libraries/ReactNative/renderApplication.js

@@ -9,10 +9,7 @@
  */
 
 import type {ViewStyleProp} from '../StyleSheet/StyleSheet';
-import type {IPerformanceLogger} from '../Utilities/createPerformanceLogger';
 
-import GlobalPerformanceLogger from '../Utilities/GlobalPerformanceLogger';
-import PerformanceLoggerContext from '../Utilities/PerformanceLoggerContext';
 import AppContainer from './AppContainer';
 import DisplayMode, {type DisplayModeType} from './DisplayMode';
 import getCachedComponentWithDebugName from './getCachedComponentWithDebugName';
@@ -39,27 +36,26 @@ export default function renderApplication<Props extends Object>(
   // Keep this parameter for backwards compatibility only. It is always treated as
   // true internally.
   fabric?: true | void,
-  scopedPerformanceLogger?: IPerformanceLogger,
+  // Reserved positional slot (formerly `scopedPerformanceLogger`). Preserved so
+  // existing callers that supply this argument continue to type-check; the
+  // value is ignored.
+  _unused?: void,
   isLogBox?: boolean,
   debugName?: string,
   displayMode?: ?DisplayModeType,
   useOffscreen?: boolean,
 ) {
   invariant(rootTag, 'Expect to have a valid rootTag, instead got ', rootTag);
 
-  const performanceLogger = scopedPerformanceLogger ?? GlobalPerformanceLogger;
-
   let renderable: React.MixedElement = (
-    <PerformanceLoggerContext.Provider value={performanceLogger}>
-      <AppContainer
-        rootTag={rootTag}
-        WrapperComponent={WrapperComponent}
-        rootViewStyle={rootViewStyle}
-        initialProps={initialProps ?? Object.freeze({})}
-        internal_excludeLogBox={isLogBox}>
-        <RootComponent {...initialProps} rootTag={rootTag} />
-      </AppContainer>
-    </PerformanceLoggerContext.Provider>
+    <AppContainer
+      rootTag={rootTag}
+      WrapperComponent={WrapperComponent}
+      rootViewStyle={rootViewStyle}
+      initialProps={initialProps ?? Object.freeze({})}
+      internal_excludeLogBox={isLogBox}>
+      <RootComponent {...initialProps} rootTag={rootTag} />
+    </AppContainer>
   );
 
   if (__DEV__ && debugName) {
@@ -74,9 +70,6 @@ export default function renderApplication<Props extends Object>(
   }
 
   if (useOffscreen && displayMode != null) {
-    // $FlowFixMe[incompatible-type]
-    // $FlowFixMe[prop-missing]
-    // $FlowFixMe[missing-export]
     const Activity: ActivityType = React.unstable_Activity;
 
     renderable = (
@@ -87,18 +80,10 @@ export default function renderApplication<Props extends Object>(
     );
   }
 
-  performanceLogger.startTimespan('renderApplication_React_render');
-  performanceLogger.setExtra('usedReactConcurrentRoot', '1');
-  performanceLogger.setExtra('usedReactFabric', '1');
-  performanceLogger.setExtra(
-    'usedReactProfiler',
-    Renderer.isProfilingRenderer(),
-  );
   Renderer.renderElement({
     element: renderable,
     rootTag,
     useFabric: true,
     useConcurrentRoot: true,
   });
-  performanceLogger.stopTimespan('renderApplication_React_render');
 }