fix(android,ios): rebase onto CanvasEffectSpan rename + iOS Wavy stub

Three CI breakages were introduced by changes that landed on `main`
between the original PR push and now:

1. PR #56705 renamed `DrawCommandSpan` to `CanvasEffectSpan` and dropped
   the `ReactSpan` / `UpdateAppearance` interfaces from the base class.
   `ReactUnderlineSpan` and `ReactStrikethroughSpan` were extending the
   old name; rename them and re-declare `ReactSpan` so they remain
   valid `SetSpanOperation` arguments. `ReactTextView.onDraw` updated
   to import the new name.

2. Adding `Wavy` to `facebook::react::TextDecorationStyle` (this PR)
   left `RCTNSUnderlineStyleFromTextDecorationStyle` non-exhaustive,
   tripping `-Werror,-Wreturn-type` on iOS builds. Add a `Wavy` case
   that falls back to a solid underline (the actual wavy rendering
   ships in companion PR #56769).

3. `validate_cxx_api_snapshots` flagged the missing `Wavy` entry in
   all six snapshots under `scripts/cxx-api/api-snapshots/`.
   Regenerate.

No behavior change beyond what was already in the feature commit; this
is purely "rebase the implementation onto current `main`."

Author: quantizor

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java

@@ -46,7 +46,7 @@
 import com.facebook.react.uimanager.style.BorderStyle;
 import com.facebook.react.uimanager.style.LogicalEdge;
 import com.facebook.react.uimanager.style.Overflow;
-import com.facebook.react.views.text.internal.span.DrawCommandSpan;
+import com.facebook.react.views.text.internal.span.CanvasEffectSpan;
 import com.facebook.react.views.text.internal.span.ReactFragmentIndexSpan;
 import com.facebook.react.views.text.internal.span.ReactTagSpan;
 import com.facebook.yoga.YogaMeasureMode;
@@ -218,12 +218,12 @@ protected void onDraw(Canvas canvas) {
       if (spanned != null) {
         Layout layout = getLayout();
         if (layout != null) {
-          DrawCommandSpan[] drawSpans =
-              spanned.getSpans(0, spanned.length(), DrawCommandSpan.class);
+          CanvasEffectSpan[] drawSpans =
+              spanned.getSpans(0, spanned.length(), CanvasEffectSpan.class);
           if (drawSpans.length > 0) {
             canvas.save();
             canvas.translate(getCompoundPaddingLeft(), getExtendedPaddingTop());
-            for (DrawCommandSpan span : drawSpans) {
+            for (CanvasEffectSpan span : drawSpans) {
               int start = spanned.getSpanStart(span);
               int end = spanned.getSpanEnd(span);
               span.onDraw(start, end, canvas, layout);

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/internal/span/ReactStrikethroughSpan.kt

@@ -26,7 +26,7 @@ import com.facebook.react.views.text.drawSpannedDecoration
 internal class ReactStrikethroughSpan(
     private val color: Int = Color.TRANSPARENT,
     private val style: TextDecorationStyle = TextDecorationStyle.SOLID,
-) : DrawCommandSpan() {
+) : CanvasEffectSpan(), ReactSpan {
 
   override fun onDraw(start: Int, end: Int, canvas: Canvas, layout: Layout) {
     drawSpannedDecoration(start, end, canvas, layout, color, style) { paint, baseline, _ ->

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/internal/span/ReactUnderlineSpan.kt

@@ -27,7 +27,7 @@ import com.facebook.react.views.text.drawSpannedDecoration
 internal class ReactUnderlineSpan(
     private val color: Int = Color.TRANSPARENT,
     private val style: TextDecorationStyle = TextDecorationStyle.SOLID,
-) : DrawCommandSpan() {
+) : CanvasEffectSpan(), ReactSpan {
 
   override fun onDraw(start: Int, end: Int, canvas: Canvas, layout: Layout) {
     drawSpannedDecoration(start, end, canvas, layout, color, style) { _, baseline, thickness ->

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTTextPrimitivesConversions.h

@@ -110,6 +110,8 @@ inline static NSUnderlineStyle RCTNSUnderlineStyleFromTextDecorationStyle(
       return NSUnderlineStylePatternDash | NSUnderlineStyleSingle;
     case facebook::react::TextDecorationStyle::Dotted:
       return NSUnderlineStylePatternDot | NSUnderlineStyleSingle;
+    case facebook::react::TextDecorationStyle::Wavy:
+      return NSUnderlineStyleSingle;
   }
 }
 

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

@@ -6505,6 +6505,7 @@ enum facebook::react::TextDecorationStyle {
   Dotted,
   Double,
   Solid,
+  Wavy,
 }
 
 enum facebook::react::TextTransform {

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

@@ -6496,6 +6496,7 @@ enum facebook::react::TextDecorationStyle {
   Dotted,
   Double,
   Solid,
+  Wavy,
 }
 
 enum facebook::react::TextTransform {

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -9073,6 +9073,7 @@ enum facebook::react::TextDecorationStyle {
   Dotted,
   Double,
   Solid,
+  Wavy,
 }
 
 enum facebook::react::TextInputAccessoryVisibilityMode {

scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api

@@ -9064,6 +9064,7 @@ enum facebook::react::TextDecorationStyle {
   Dotted,
   Double,
   Solid,
+  Wavy,
 }
 
 enum facebook::react::TextInputAccessoryVisibilityMode {

scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api

@@ -4856,6 +4856,7 @@ enum facebook::react::TextDecorationStyle {
   Dotted,
   Double,
   Solid,
+  Wavy,
 }
 
 enum facebook::react::TextTransform {

scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api

@@ -4847,6 +4847,7 @@ enum facebook::react::TextDecorationStyle {
   Dotted,
   Double,
   Solid,
+  Wavy,
 }
 
 enum facebook::react::TextTransform {