Enable E2E retries on all branches and simplify rerun-failed-jobs

- Remove the PR-only guard from retry jobs so they also run on main
  and stable branches, providing consistent retry behavior everywhere
- Simplify rerun-failed-jobs to only handle Fantom tests, since E2E
  retries are now handled by the in-workflow retry_1/retry_2 jobs

Author: cipolleschi

.github/workflows/test-all.yml

@@ -161,14 +161,14 @@ jobs:
 
   test_e2e_ios_rntester_retry_1:
     needs: test_e2e_ios_rntester
-    if: ${{ github.event_name == 'pull_request' && always() && needs.test_e2e_ios_rntester.outputs.status == 'failure' }}
+    if: ${{ always() && needs.test_e2e_ios_rntester.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-ios-rntester.yml
     continue-on-error: true
     secrets: inherit
 
   test_e2e_ios_rntester_retry_2:
     needs: test_e2e_ios_rntester_retry_1
-    if: ${{ github.event_name == 'pull_request' && always() && needs.test_e2e_ios_rntester_retry_1.outputs.status == 'failure' }}
+    if: ${{ always() && needs.test_e2e_ios_rntester_retry_1.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-ios-rntester.yml
     continue-on-error: true
     secrets: inherit
@@ -181,14 +181,14 @@ jobs:
 
   test_e2e_ios_templateapp_retry_1:
     needs: test_e2e_ios_templateapp
-    if: ${{ github.event_name == 'pull_request' && always() && needs.test_e2e_ios_templateapp.outputs.status == 'failure' }}
+    if: ${{ always() && needs.test_e2e_ios_templateapp.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-ios-templateapp.yml
     continue-on-error: true
     secrets: inherit
 
   test_e2e_ios_templateapp_retry_2:
     needs: test_e2e_ios_templateapp_retry_1
-    if: ${{ github.event_name == 'pull_request' && always() && needs.test_e2e_ios_templateapp_retry_1.outputs.status == 'failure' }}
+    if: ${{ always() && needs.test_e2e_ios_templateapp_retry_1.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-ios-templateapp.yml
     continue-on-error: true
     secrets: inherit
@@ -201,14 +201,14 @@ jobs:
 
   test_e2e_android_templateapp_retry_1:
     needs: test_e2e_android_templateapp
-    if: ${{ github.event_name == 'pull_request' && always() && needs.test_e2e_android_templateapp.outputs.status == 'failure' }}
+    if: ${{ always() && needs.test_e2e_android_templateapp.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-android-templateapp.yml
     continue-on-error: true
     secrets: inherit
 
   test_e2e_android_templateapp_retry_2:
     needs: test_e2e_android_templateapp_retry_1
-    if: ${{ github.event_name == 'pull_request' && always() && needs.test_e2e_android_templateapp_retry_1.outputs.status == 'failure' }}
+    if: ${{ always() && needs.test_e2e_android_templateapp_retry_1.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-android-templateapp.yml
     continue-on-error: true
     secrets: inherit
@@ -284,14 +284,14 @@ jobs:
 
   test_e2e_android_rntester_retry_1:
     needs: test_e2e_android_rntester
-    if: ${{ github.event_name == 'pull_request' && always() && needs.test_e2e_android_rntester.outputs.status == 'failure' }}
+    if: ${{ always() && needs.test_e2e_android_rntester.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-android-rntester.yml
     continue-on-error: true
     secrets: inherit
 
   test_e2e_android_rntester_retry_2:
     needs: test_e2e_android_rntester_retry_1
-    if: ${{ github.event_name == 'pull_request' && always() && needs.test_e2e_android_rntester_retry_1.outputs.status == 'failure' }}
+    if: ${{ always() && needs.test_e2e_android_rntester_retry_1.outputs.status == 'failure' }}
     uses: ./.github/workflows/e2e-android-rntester.yml
     continue-on-error: true
     secrets: inherit
@@ -506,18 +506,11 @@ jobs:
         shell: bash
         run: node scripts/debugger-shell/build-binary.js
 
-  # This job should help with the E2E flakyness.
-  # In case E2E tests fails, it launches a new retry-workflow workflow, passing the current run_id as input.
-  # The retry-workflow reruns only the failed jobs of the current test-all workflow using
-  # ```
-  # gh run rerun ${{ inputs.run_id }} --failed
-  # ```
-  # From https://stackoverflow.com/a/78314483 it seems like that adding the extra workflow
-  # rather then calling directly this command should improve stability of this solution.
-  # This is exactly the same as rerunning failed tests from the GH UI, but automated.
+  # E2E test retries are now handled by the retry_1/retry_2 reusable workflow jobs above.
+  # This job only handles Fantom test retries on main.
   rerun-failed-jobs:
     runs-on: ubuntu-latest
-    needs: [test_e2e_ios_rntester, test_e2e_android_rntester, test_e2e_ios_templateapp, test_e2e_android_templateapp, run_fantom_tests]
+    needs: [run_fantom_tests]
     if: ${{ github.ref == 'refs/heads/main' && always() }}
     steps:
       - name: Checkout
@@ -531,19 +524,10 @@ jobs:
             exit 0
           fi
 
-          RNTESTER_ANDROID_FAILED=${{ needs.test_e2e_android_rntester.result == 'failure' }}
-          TEMPLATE_ANDROID_FAILED=${{ needs.test_e2e_android_templateapp.result == 'failure' }}
-          RNTESTER_IOS_FAILED=${{ needs.test_e2e_ios_rntester.result == 'failure' }}
-          TEMPLATE_IOS_FAILED=${{ needs.test_e2e_ios_templateapp.result == 'failure' }}
           FANTOM_TESTS_FAILED=${{ needs.run_fantom_tests.result == 'failure' }}
-
-          echo "RNTESTER_ANDROID_FAILED: $RNTESTER_ANDROID_FAILED"
-          echo "TEMPLATE_ANDROID_FAILED: $TEMPLATE_ANDROID_FAILED"
-          echo "RNTESTER_IOS_FAILED: $RNTESTER_IOS_FAILED"
-          echo "TEMPLATE_IOS_FAILED: $TEMPLATE_IOS_FAILED"
           echo "FANTOM_TESTS_FAILED: $FANTOM_TESTS_FAILED"
 
-          if [[ $RNTESTER_ANDROID_FAILED == "true" || $TEMPLATE_ANDROID_FAILED == "true" || $RNTESTER_IOS_FAILED == "true" || $TEMPLATE_IOS_FAILED == "true" || $FANTOM_TESTS_FAILED == "true" ]]; then
+          if [[ $FANTOM_TESTS_FAILED == "true" ]]; then
             echo "Rerunning failed jobs in the current workflow"
             gh workflow run retry-workflow.yml -F run_id=${{ github.run_id }}
           fi