Commit 7aae556
Remove RCT_EXPORT_MODULE from Core modules (#54288)
Summary:
Pull Request resolved: #54288
This change remove the usage of RCT_EXPORT_MODULE from all the classes of React Native Core.
This allow us to remove the +load method that runs at initialization of React Native and that can slow down the start of React Native itself.
All the classes are still registered due to the [`RCTBridge`'s `getCoreModuleClasses`](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Base/RCTBridge.mm#L46) which manually lists all the classes that got modified.
---
## TODO
There are some classes that should be loaded using the respective plugins. Currently, the OSS implementation only uses the [CoreModulePlugin](https://github.com/facebook/react-native/blob/main/packages/react-native/React/CoreModules/CoreModulesPlugins.mm#L19), but we should add the lookup also in these others plugins:
- RCTBlobPlugins.mm
- RCTImagePlugins.mm
- RCTNetworkPlugins.mm
- RCTSettingsPlugins.mm
- RCTLinkingPlugins.mm
- RCTVibrationPlugins.mm
- RCTAnimationPlugins.mm
- RCTPushNotificationPlugins.mm (if the import is available. The push notification module is not included by default)
## Changelog:
[Internal] - Remove RCT_EXPORT_MODULE from RN Core Modules
Reviewed By: javache
Differential Revision: D85580258
fbshipit-source-id: 6df6002afdcd2d7344a4a9fb2674a9f34c7abc1e1 parent fe18f1f commit 7aae556
62 files changed
Lines changed: 249 additions & 62 deletions
File tree
- packages/react-native
- Libraries
- Blob
- Image
- LinkingIOS
- NativeAnimation
- Network
- PushNotificationIOS
- Settings
- Text
- BaseText
- RawText
- TextInput
- Multiline
- Singleline
- Text
- VirtualText
- Vibration
- ReactCommon/react/nativemodule/samples/platform/ios/ReactCommon
- React
- CoreModules
- Modules
- Views
- RefreshControl
- SafeAreaView
- ScrollView
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
46 | 49 | | |
47 | 50 | | |
48 | 51 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
96 | 99 | | |
97 | 100 | | |
98 | 101 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
36 | 39 | | |
37 | 40 | | |
38 | 41 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
31 | 34 | | |
32 | 35 | | |
33 | 36 | | |
| |||
0 commit comments