Skip to content

Commit 814a2cd

Browse files
hoxyqmeta-codesync[bot]
authored andcommitted
Hide Performance Monitor when tracing in RNDT (#54828)
Summary: Pull Request resolved: #54828 # Changelog: [Internal] As titled. Before this change, monitor was just disabled, but was shown in the UI. I think we should completely hide it, so it doesn't contribute to any frames or screenshots data. Since the trace is already initialized from the RNDT, user has already expressed the intent for tracing, we don't need to show it in the UI. Reviewed By: huntie Differential Revision: D88748037 fbshipit-source-id: 899d25f25ac8c4633448d2132f99b478f8375265
1 parent 4d6a450 commit 814a2cd

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayManager.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,11 @@ internal class PerfMonitorOverlayManager(
8383
UiThreadUtil.runOnUiThread {
8484
view?.updateRecordingState(state)
8585
view?.updatePerfIssueCount(perfIssueCount)
86-
view?.show()
86+
if (state == TracingState.ENABLED_IN_CDP_MODE) {
87+
view?.hide()
88+
} else {
89+
view?.show()
90+
}
8791
}
8892
}
8993

0 commit comments

Comments
 (0)