Skip to content

Commit 8448f09

Browse files
committed
Fix setup for hermes in CI
1 parent 350a654 commit 8448f09

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

scripts/releases/utils/hermes-utils.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ async function getLatestHermesNightlyVersion() /*: Promise<{
4343

4444
return {
4545
compilerVersion,
46+
compilerV1Version,
4647
// runtime version should match the compiler version
4748
runtimeVersion: compilerVersion,
4849
runtimeV1Version: compilerV1Version,
@@ -84,7 +85,7 @@ async function updateHermesRuntimeDependenciesVersions(
8485
async function updateHermesVersionsToNightly() {
8586
const hermesVersions = await getLatestHermesNightlyVersion();
8687
await updateHermesCompilerVersionInDependencies(
87-
hermesVersions.compilerVersion,
88+
hermesVersions.compilerV1Version,
8889
);
8990
await updateHermesRuntimeDependenciesVersions(
9091
hermesVersions.runtimeVersion,

scripts/try-set-nightly-hermes-compiler.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ function main() {
1717

1818
if (hermesCompilerVersion === '0.0.0') {
1919
console.log(`Hermes compiler version not set. Updating to the latest nightly release.`);
20-
// We are not publishing a nightly version of hermes-compiler for v1,
21-
// so we need to manually set the version to the latest nightly release.
22-
execSync('yarn workspace react-native add hermes-compiler@latest-v1 --exact', { stdio: 'inherit' });
20+
execSync('yarn workspace react-native add hermes-compiler@nightly --exact', { stdio: 'inherit' });
2321
} else {
2422
console.log(`Hermes compiler version set to ${hermesCompilerVersion}. Not setting nightly hermes.`);
2523
}

0 commit comments

Comments
 (0)