removed unstable functions tracking the existance of connected devices (#55008)

Summary:
Pull Request resolved: #55008

Changelog: [Internal] removed an unstable function briefly added in #54447

This was previously added in #54447, but not needed anymore as we found a different way to get this information without exposing a special API for that.

Reviewed By: robhogan

Differential Revision: D89962175

fbshipit-source-id: 3636ef8815678781ee39ef8211f00bde69b5ce63

Author: vzaidman

packages/dev-middleware/src/createDevMiddleware.js

@@ -9,7 +9,6 @@
  */
 
 import type {CreateCustomMessageHandlerFn} from './inspector-proxy/CustomMessageHandler';
-import type {HasConnectedDevicesListener} from './inspector-proxy/InspectorProxy';
 import type {BrowserLauncher} from './types/BrowserLauncher';
 import type {EventReporter, ReportableEvent} from './types/EventReporter';
 import type {Experiments, ExperimentsConfig} from './types/Experiments';
@@ -74,8 +73,6 @@ type Options = $ReadOnly<{
 type DevMiddlewareAPI = $ReadOnly<{
   middleware: NextHandleFunction,
   websocketEndpoints: {[path: string]: ws$WebSocketServer},
-  unstable_hasConnectedDevices(): boolean,
-  unstable_addHasConnectedDevicesListener: HasConnectedDevicesListener,
 }>;
 
 export default function createDevMiddleware({
@@ -134,10 +131,6 @@ export default function createDevMiddleware({
   return {
     middleware,
     websocketEndpoints: inspectorProxy.createWebSocketListeners(),
-    unstable_hasConnectedDevices: () =>
-      inspectorProxy.unstable_hasConnectedDevices(),
-    unstable_addHasConnectedDevicesListener: cb =>
-      inspectorProxy.unstable_addHasConnectedDevicesListener(cb),
   };
 }
 

packages/dev-middleware/src/inspector-proxy/InspectorProxy.js

@@ -71,12 +71,6 @@ export interface InspectorProxyQueries {
   ): Array<PageDescription>;
 }
 
-export type RemoveHasConnectedDevicesListener = () => void;
-
-export type HasConnectedDevicesListener = (
-  callback: (hasConnectedDevices: boolean) => void,
-) => RemoveHasConnectedDevicesListener;
-
 /**
  * Main Inspector Proxy class that connects JavaScript VM inside Android/iOS apps and JS debugger.
  */
@@ -103,8 +97,6 @@ export default class InspectorProxy implements InspectorProxyQueries {
 
   #eventLoopPerfTracker: EventLoopPerfTracker;
 
-  #onHasConnectedDevicesChangedFns: Set<(boolean) => void>;
-
   constructor(
     serverBaseUrl: string,
     eventReporter: ?EventReporter,
@@ -119,7 +111,6 @@ export default class InspectorProxy implements InspectorProxyQueries {
     this.#experiments = experiments;
     this.#logger = logger;
     this.#customMessageHandler = customMessageHandler;
-    this.#onHasConnectedDevicesChangedFns = new Set();
     if (trackEventLoopPerf) {
       this.#eventLoopPerfTracker = new EventLoopPerfTracker({
         perfMeasurementDuration: EVENT_LOOP_PERF_MEASUREMENT_MS,
@@ -151,18 +142,6 @@ export default class InspectorProxy implements InspectorProxyQueries {
     }
   }
 
-  unstable_hasConnectedDevices(): boolean {
-    return this.#devices.size > 0;
-  }
-
-  unstable_addHasConnectedDevicesListener: HasConnectedDevicesListener =
-    onDevicesChanged => {
-      this.#onHasConnectedDevicesChangedFns.add(onDevicesChanged);
-      return () => {
-        this.#onHasConnectedDevicesChangedFns.delete(onDevicesChanged);
-      };
-    };
-
   getPageDescriptions({
     requestorRelativeBaseUrl,
     logNoPagesForConnectedDevice = false,
@@ -386,9 +365,6 @@ export default class InspectorProxy implements InspectorProxyQueries {
         }
 
         this.#devices.set(deviceId, newDevice);
-        if (this.#devices.size === 1) {
-          this.#onHasConnectedDevicesChangedFns.forEach(cb => cb(true));
-        }
 
         debug(
           "Got new device connection: name='%s', app=%s, device=%s, via=%s",
@@ -481,9 +457,6 @@ export default class InspectorProxy implements InspectorProxyQueries {
 
           if (this.#devices.get(deviceId)?.dangerouslyGetSocket() === socket) {
             this.#devices.delete(deviceId);
-            if (this.#devices.size === 0) {
-              this.#onHasConnectedDevicesChangedFns.forEach(cb => cb(false));
-            }
           }
         });
       } catch (error) {