Skip to content

Commit b807253

Browse files
author
Riccardo
authored
Merge pull request #34223 from facebook/fix/hermes_in_release
Fix/hermes in release
2 parents a19578d + d6be1af commit b807253

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

.circleci/config.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -937,8 +937,17 @@ jobs:
937937
name: Download Hermes tarball
938938
command: |
939939
node scripts/hermes/prepare-hermes-for-build
940-
cp sdks/download/* $HERMES_WS_DIR/download/.
941-
cp -r sdks/hermes/* $HERMES_WS_DIR/hermes/.
940+
941+
# If Hermes is not built from source, we don't have these folders.
942+
DOWNLOAD_FOLDER=sdks/download/
943+
if [[ -d $DOWNLOAD_FOLDER ]]; then
944+
cp $DOWNLOAD_FOLDER* $HERMES_WS_DIR/download/.
945+
fi
946+
947+
HERMES_FOLDER=sdks/hermes/
948+
if [[ -d $HERMES_FOLDER ]]; then
949+
cp -r $HERMES_FOLDER* $HERMES_WS_DIR/hermes/.
950+
fi
942951
- save_cache:
943952
key: v1-hermes-{{ .Environment.CIRCLE_JOB }}-{{ checksum "/tmp/hermes/hermesversion" }}
944953
paths:

scripts/hermes/hermes-utils.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ function isOnAReleaseTag() {
192192

193193
function shouldBuildHermesFromSource() {
194194
const hermesTag = readHermesTag();
195+
195196
return (
196197
isOnAReleaseBranch() ||
197198
isOnAReleaseTag() ||

0 commit comments

Comments
 (0)