Use category to control JavaScript sampling profiler (#54381)

Summary:
Pull Request resolved: #54381

# Changelog: [Internal]

Now, instead of controlling the data sources based on tracing mode, we can control them based on enabled categories.

`JavaScriptSampling` category is not enabled in JReactHostInspectorTarget, which allows the Host to control this.

Reviewed By: huntie

Differential Revision: D85996395

fbshipit-source-id: 4d3495ae0393854ecca1e24ab44546a65bc87733

Author: hoxyq

packages/react-native/ReactCommon/jsinspector-modern/RuntimeAgent.cpp

@@ -152,13 +152,14 @@ RuntimeTracingAgent::RuntimeTracingAgent(
     tracing::TraceRecordingState& state,
     RuntimeTargetController& targetController)
     : tracing::TargetTracingAgent(state), targetController_(targetController) {
-  if (state.mode == tracing::Mode::CDP) {
+  if (state.enabledCategories.contains(tracing::Category::JavaScriptSampling)) {
     targetController_.enableSamplingProfiler();
   }
 }
 
 RuntimeTracingAgent::~RuntimeTracingAgent() {
-  if (state_.mode == tracing::Mode::CDP) {
+  if (state_.enabledCategories.contains(
+          tracing::Category::JavaScriptSampling)) {
     targetController_.disableSamplingProfiler();
     auto profile = targetController_.collectSamplingProfile();
 

packages/react-native/ReactCommon/jsinspector-modern/tests/TracingTest.cpp

@@ -0,0 +1,59 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include "TracingTest.h"
+#include "engines/JsiIntegrationTestHermesEngineAdapter.h"
+
+#include <folly/executors/QueuedImmediateExecutor.h>
+#include <jsinspector-modern/InspectorFlags.h>
+#include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/networking/NetworkReporter.h>
+
+using namespace ::testing;
+
+namespace facebook::react::jsinspector_modern {
+
+class TracingTest : public TracingTestBase<
+                        JsiIntegrationTestHermesEngineAdapter,
+                        folly::QueuedImmediateExecutor> {
+ protected:
+  TracingTest() : TracingTestBase() {}
+
+  void SetUp() override {
+    JsiIntegrationPortableTestBase::SetUp();
+    connect();
+    EXPECT_CALL(
+        fromPage(),
+        onMessage(
+            JsonParsed(AllOf(AtJsonPtr("/method", "Debugger.scriptParsed")))))
+        .Times(AnyNumber());
+  }
+};
+
+TEST_F(TracingTest, EnablesSamplingProfilerOnlyCategoryIsSpecified) {
+  InSequence s;
+
+  startTracing({});
+  auto allTraceEvents = endTracingAndCollectEvents();
+
+  EXPECT_THAT(
+      allTraceEvents,
+      Not(Contains(AllOf(
+          AtJsonPtr("/name", "Profile"),
+          AtJsonPtr("/cat", "disabled-by-default-v8.cpu_profiler")))));
+
+  startTracing({tracing::Category::JavaScriptSampling});
+  allTraceEvents = endTracingAndCollectEvents();
+
+  EXPECT_THAT(
+      allTraceEvents,
+      Contains(AllOf(
+          AtJsonPtr("/name", "Profile"),
+          AtJsonPtr("/cat", "disabled-by-default-v8.cpu_profiler"))));
+}
+
+} // namespace facebook::react::jsinspector_modern