Remove the legacy arch by default (#54894)

Summary:
This change remove the legacy arch by default from React Native iOS.

Users can still put the code back by using `RCT_REMOVE_LEGACY_ARCH=0 bundle exec pod install`

## Changelog:
[iOS][Breaking] - Remove legacy arch by default

Pull Request resolved: #54894

Test Plan:
Tested with RNTester that the app build correctly.
Also verified that the artifacts produced by the prebuilds are smaller than the one built before the change.

Reviewed By: vzaidman

Differential Revision: D89276102

Pulled By: cipolleschi

fbshipit-source-id: b865311c73e4f5b5b3e0b327e065f33605782e66

Author: cipolleschi

packages/react-native/Package.swift

@@ -923,6 +923,7 @@ extension Target {
         .define("DEBUG", .when(configuration: .debug)),
         .define("NDEBUG", .when(configuration: .release)),
         .define("USE_HERMES", to: "1"),
+        .define("RCT_REMOVE_LEGACY_ARCH", to: "1"),
       ] + defines + cxxCommonHeaderPaths
 
     return .target(

packages/react-native/scripts/react_native_pods.rb

@@ -88,6 +88,9 @@ def use_react_native! (
   # Users can still turn them off and build from source by setting the environment variable to 0.
   ENV['RCT_USE_RN_DEP'] = ENV['RCT_USE_RN_DEP'] == '0' ? '0' : '1'
   ENV['RCT_USE_PREBUILT_RNCORE'] = ENV['RCT_USE_PREBUILT_RNCORE'] == '0' ? '0' : '1'
+  # Make `REMOVE_LEGACY_ARCH` enabled by default. This will build React Native
+  # excluding the legacy arch unless the user turns this flag off explicitly.
+  ENV['RCT_REMOVE_LEGACY_ARCH'] = ENV['RCT_REMOVE_LEGACY_ARCH'] == '0' ? '0' : '1'
 
   ReactNativePodsUtils.check_minimum_required_xcode()