Skip to content

Commit e189075

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Update detail key used for Performance Issues (#54410)
Summary: Pull Request resolved: #54410 See https://github.com/reactwg/react/discussions/400 Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D86189162 fbshipit-source-id: f42ec6851819237464168a1fc3465a4f0d20b701
1 parent dcee4b9 commit e189075

5 files changed

Lines changed: 11 additions & 9 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<15ede8025e516f2bdc0329efe49f4a62>>
7+
* @generated SignedSource<<890156e9513bff7c7c6252f8cf4402e4>>
88
*/
99

1010
/**
@@ -379,7 +379,7 @@ public object ReactNativeFeatureFlags {
379379
public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()
380380

381381
/**
382-
* Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
382+
* Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
383383
*/
384384
@JvmStatic
385385
public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<ce6f11b805b3de79c414d1893cd7b2cc>>
7+
* @generated SignedSource<<7e530e01e8c31edb68099a11bc371b89>>
88
*/
99

1010
/**
@@ -330,7 +330,7 @@ class ReactNativeFeatureFlags {
330330
RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();
331331

332332
/**
333-
* Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
333+
* Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
334334
*/
335335
RN_EXPORT static bool perfIssuesEnabled();
336336

packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpPerfIssuesReporter.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,10 @@ void CdpPerfIssuesReporter::onMeasureEntry(
4242
return;
4343
}
4444

45-
if (detail.count("rnPerfIssue") != 0 && detail["rnPerfIssue"].isObject()) {
46-
auto& perfIssue = detail["rnPerfIssue"];
45+
if (detail.count("devtools") != 0 && detail["devtools"].isObject() &&
46+
detail["devtools"].count("performanceIssue") != 0 &&
47+
detail["devtools"]["performanceIssue"].isObject()) {
48+
auto& perfIssue = detail["devtools"]["performanceIssue"];
4749

4850
if (perfIssue.count("name") != 0 && perfIssue.count("severity") != 0 &&
4951
perfIssue.count("description") != 0) {

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -671,7 +671,7 @@ const definitions: FeatureFlagDefinitions = {
671671
metadata: {
672672
dateAdded: '2025-10-24',
673673
description:
674-
'Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.',
674+
'Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.',
675675
expectedReleaseValue: true,
676676
purpose: 'experimentation',
677677
},

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<9284928dae8d148f3ce8041fdbe84990>>
7+
* @generated SignedSource<<dcec3cf74137d4a43dcaa0b330fba44a>>
88
* @flow strict
99
* @noformat
1010
*/
@@ -446,7 +446,7 @@ export const hideOffscreenVirtualViewsOnIOS: Getter<boolean> = createNativeFlagG
446446
*/
447447
export const overrideBySynchronousMountPropsAtMountingAndroid: Getter<boolean> = createNativeFlagGetter('overrideBySynchronousMountPropsAtMountingAndroid', false);
448448
/**
449-
* Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
449+
* Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
450450
*/
451451
export const perfIssuesEnabled: Getter<boolean> = createNativeFlagGetter('perfIssuesEnabled', false);
452452
/**

0 commit comments

Comments
 (0)