Skip to content

Commit e99f8f9

Browse files
rubennortemeta-codesync[bot]
authored andcommitted
Remove redundant feature flag overrides (#56014)
Summary: Pull Request resolved: #56014 Changelog: [internal] Clean up React Native feature flag override classes by removing overrides that return values identical to their parent class defaults: - **ReactNativeNewArchitectureFeatureFlagsDefaults**: Removed unnecessary `newArchitectureEnabled` constant and simplified method returns to direct `true` values - **ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android**: Removed redundant `useFabricInterop()` override (default is already `true`) These changes improve code maintainability by eliminating unnecessary duplication without any behavioral impact. Reviewed By: huntie Differential Revision: D95852632 fbshipit-source-id: 89cb210210911d646ff2a2ea5bac6861730cf978
1 parent b8876b5 commit e99f8f9

2 files changed

Lines changed: 6 additions & 13 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,4 @@
88
package com.facebook.react.internal.featureflags
99

1010
public class ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android() :
11-
ReactNativeNewArchitectureFeatureFlagsDefaults() {
12-
13-
override fun useFabricInterop(): Boolean = true
14-
}
11+
ReactNativeNewArchitectureFeatureFlagsDefaults()

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,13 @@ package com.facebook.react.internal.featureflags
2323
public open class ReactNativeNewArchitectureFeatureFlagsDefaults() :
2424
ReactNativeFeatureFlagsDefaults() {
2525

26-
private val newArchitectureEnabled: Boolean = true
26+
override fun enableBridgelessArchitecture(): Boolean = true
2727

28-
override fun enableBridgelessArchitecture(): Boolean = newArchitectureEnabled
28+
override fun enableFabricRenderer(): Boolean = true
2929

30-
override fun enableFabricRenderer(): Boolean = newArchitectureEnabled
30+
override fun useNativeViewConfigsInBridgelessMode(): Boolean = true
3131

32-
override fun useNativeViewConfigsInBridgelessMode(): Boolean =
33-
newArchitectureEnabled || super.useNativeViewConfigsInBridgelessMode()
32+
override fun useTurboModuleInterop(): Boolean = true
3433

35-
override fun useTurboModuleInterop(): Boolean =
36-
newArchitectureEnabled || super.useTurboModuleInterop()
37-
38-
override fun useTurboModules(): Boolean = newArchitectureEnabled
34+
override fun useTurboModules(): Boolean = true
3935
}

0 commit comments

Comments
 (0)