Sync RCTNativeSampleTurboModuleSpec (#54918)

Summary:
Pull Request resolved: #54918

This is a checked-in copy of codegen (not sure why) which is out-of-date and prevents me from investigating the backwards-compat regression in D89373357

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D89373356

fbshipit-source-id: 05433bca43120656710a15460b61d6cb64a57aad

Author: javache

packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec

@@ -53,6 +53,7 @@ Pod::Spec.new do |s|
   s.dependency "React-Core"
   s.dependency "React-cxxreact"
   s.dependency "React-jsi"
+  s.dependency "RCTTypeSafety"
   add_dependency(s, "React-RCTFBReactNativeSpec")
   add_dependency(s, "ReactCommon", :subspec => "turbomodule/core", :additional_framework_paths => ["react/nativemodule/core"])
   add_dependency(s, "React-NativeModulesApple")

packages/react-native/ReactCommon/react/nativemodule/samples/platform/android/NativeSampleTurboModuleSpec.java

@@ -9,6 +9,7 @@
 
 package com.facebook.fbreact.specs;
 
+import com.facebook.proguard.annotations.DoNotStrip;
 import com.facebook.react.bridge.Callback;
 import com.facebook.react.bridge.Promise;
 import com.facebook.react.bridge.ReactApplicationContext;
@@ -52,13 +53,14 @@ protected final void emitOnChange(ReadableMap value) {
     mEventEmitterCallback.invoke("onChange", value);
   }
 
-  protected void emitOnSubmit(ReadableArray value) {
+  protected final void emitOnSubmit(ReadableArray value) {
     mEventEmitterCallback.invoke("onSubmit", value);
   }
 
   protected abstract Map<String, Object> getTypedExportedConstants();
 
   @Override
+  @DoNotStrip
   public final @Nullable Map<String, Object> getConstants() {
     Map<String, Object> constants = getTypedExportedConstants();
     if (ReactBuildConfig.DEBUG || ReactBuildConfig.IS_INTERNAL_BUILD) {
@@ -70,78 +72,97 @@ protected void emitOnSubmit(ReadableArray value) {
       undeclaredConstants.removeAll(optionalFlowConstants);
       if (!undeclaredConstants.isEmpty()) {
         throw new IllegalStateException(
-            "Native Module Flow doesn't declare constants: " + undeclaredConstants);
+            String.format("Native Module Flow doesn't declare constants: %s", undeclaredConstants));
       }
       undeclaredConstants = obligatoryFlowConstants;
       undeclaredConstants.removeAll(constants.keySet());
       if (!undeclaredConstants.isEmpty()) {
         throw new IllegalStateException(
-            "Native Module doesn't fill in constants: " + undeclaredConstants);
+            String.format("Native Module doesn't fill in constants: %s", undeclaredConstants));
       }
     }
     return constants;
   }
 
   @ReactMethod
+  @DoNotStrip
   public abstract void voidFunc();
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public abstract boolean getBool(boolean arg);
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public double getEnum(double arg) {
     return 0;
   }
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public abstract double getNumber(double arg);
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public abstract String getString(String arg);
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public abstract WritableArray getArray(ReadableArray arg);
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public abstract WritableMap getObject(ReadableMap arg);
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public abstract WritableMap getUnsafeObject(ReadableMap arg);
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public abstract double getRootTag(double arg);
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public abstract WritableMap getValue(double x, String y, ReadableMap z);
 
   @ReactMethod
+  @DoNotStrip
   public abstract void getValueWithCallback(Callback callback);
 
   @ReactMethod
+  @DoNotStrip
   public abstract void getValueWithPromise(boolean error, Promise promise);
 
   @ReactMethod
+  @DoNotStrip
   public void voidFuncThrows() {}
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public WritableMap getObjectThrows(ReadableMap arg) {
     return null;
   }
 
   @ReactMethod
+  @DoNotStrip
   public void promiseThrows(Promise promise) {}
 
   @ReactMethod
+  @DoNotStrip
   public void voidFuncAssert() {}
 
   @ReactMethod(isBlockingSynchronousMethod = true)
+  @DoNotStrip
   public WritableMap getObjectAssert(ReadableMap arg) {
     return null;
   }
 
   @ReactMethod
+  @DoNotStrip
   public void promiseAssert(Promise promise) {}
 
   @ReactMethod
+  @DoNotStrip
   public void getImageUrl(Promise promise) {}
 }

packages/react-native/ReactCommon/react/nativemodule/samples/platform/ios/ReactCommon/RCTNativeSampleTurboModuleSpec.h

@@ -9,17 +9,78 @@
 
 #import <vector>
 
-#import <Foundation/Foundation.h>
+#ifndef __cplusplus
+#error This file must be compiled as Obj-C++. If you are importing it, you must change your file extension to .mm.
+#endif
 
+#import <Foundation/Foundation.h>
+#import <RCTRequired/RCTRequired.h>
+#import <RCTTypeSafety/RCTConvertHelpers.h>
+#import <RCTTypeSafety/RCTTypedModuleConstants.h>
 #import <React/RCTBridgeModule.h>
-
 #import <ReactCommon/RCTTurboModule.h>
 
 NS_ASSUME_NONNULL_BEGIN
 
-/**
- * The ObjC protocol based on the JS Flow type for SampleTurboModule.
- */
+namespace JS::NativeSampleTurboModule {
+struct Constants {
+  struct Builder {
+    struct Input {
+      RCTRequired<bool> const1;
+      RCTRequired<double> const2;
+      RCTRequired<NSString *> const3;
+    };
+
+    /** Initialize with a set of values */
+    Builder(const Input i);
+    /** Initialize with an existing Constants */
+    Builder(Constants i);
+    /** Builds the object. Generally used only by the infrastructure. */
+    NSDictionary *buildUnsafeRawValue() const
+    {
+      return _factory();
+    };
+
+   private:
+    NSDictionary * (^_factory)(void);
+  };
+
+  static Constants fromUnsafeRawValue(NSDictionary *const v)
+  {
+    return {v};
+  }
+  NSDictionary *unsafeRawValue() const
+  {
+    return _v;
+  }
+
+ private:
+  Constants(NSDictionary *const v) : _v(v) {}
+  NSDictionary *_v;
+};
+
+} // namespace JS::NativeSampleTurboModule
+
+inline JS::NativeSampleTurboModule::Constants::Builder::Builder(const Input i)
+    : _factory(^{
+        NSMutableDictionary *d = [NSMutableDictionary new];
+        auto const1 = i.const1.get();
+        d[@"const1"] = @(const1);
+        auto const2 = i.const2.get();
+        d[@"const2"] = @(const2);
+        auto const3 = i.const3.get();
+        d[@"const3"] = const3;
+        return d;
+      })
+{
+}
+inline JS::NativeSampleTurboModule::Constants::Builder::Builder(Constants i)
+    : _factory(^{
+        return i.unsafeRawValue();
+      })
+{
+}
+
 @protocol NativeSampleTurboModuleSpec <RCTBridgeModule, RCTTurboModule>
 
 - (void)voidFunc;
@@ -40,32 +101,32 @@ NS_ASSUME_NONNULL_BEGIN
 - (void)voidFuncAssert;
 - (NSDictionary *)getObjectAssert:(NSDictionary *)arg;
 - (void)promiseAssert:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject;
-- (NSDictionary *)constantsToExport;
-- (NSDictionary *)getConstants;
+- (void)getImageUrl:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject;
+- (facebook::react::ModuleConstants<JS::NativeSampleTurboModule::Constants>)constantsToExport;
+- (facebook::react::ModuleConstants<JS::NativeSampleTurboModule::Constants>)getConstants;
 
 @end
 
 @interface NativeSampleTurboModuleSpecBase : NSObject {
  @protected
   facebook::react::EventEmitterCallback _eventEmitterCallback;
 }
-- (void)setEventEmitterCallback:(EventEmitterCallbackWrapper *_Nonnull)eventEmitterCallbackWrapper;
+- (void)setEventEmitterCallback:(EventEmitterCallbackWrapper *)eventEmitterCallbackWrapper;
+
 - (void)emitOnPress;
-- (void)emitOnClick:(NSString *)value;
+- (void)emitOnClick:(NSString *_Nonnull)value;
 - (void)emitOnChange:(NSDictionary *)value;
-- (void)emitOnSubmit:(NSArray *)value;
+- (void)emitOnSubmit:(NSArray<id<NSObject>> *)value;
 @end
 
 namespace facebook::react {
-
 /**
- * The iOS TurboModule impl specific to SampleTurboModule.
+ * ObjC++ class for module 'NativeSampleTurboModule'
  */
 class JSI_EXPORT NativeSampleTurboModuleSpecJSI : public ObjCTurboModule {
  public:
   NativeSampleTurboModuleSpecJSI(const ObjCTurboModule::InitParams &params);
 };
-
 } // namespace facebook::react
 
 NS_ASSUME_NONNULL_END