Skip to content

Commit feede14

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Deprecate RCTTurboModuleEnabled() and RCTEnableTurboModule() (#57082)
Summary: Pull Request resolved: #57082 ## Changelog: [iOS][Fixed] Deprecate RCTTurboModuleEnabled() and RCTEnableTurboModule() Reviewed By: javache Differential Revision: D107548130 fbshipit-source-id: 51c5e42d2881d2ff7a34e3c318ee4ffb5fe6e03a
1 parent b0a6386 commit feede14

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

packages/react-native/Libraries/AppDelegate/RCTReactNativeFactory.mm

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ - (instancetype)initWithDelegate:(id<RCTReactNativeFactoryDelegate>)delegate rel
5858
[self _setUpFeatureFlags:releaseLevel];
5959

6060
[RCTColorSpaceUtils applyDefaultColorSpace:[self defaultColorSpace]];
61-
RCTEnableTurboModule(YES);
6261

6362
self.rootViewFactory = [self createRCTRootViewFactory];
6463

packages/react-native/React/Base/RCTBridge.h

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,13 @@ NSString *RCTBridgeModuleNameForClass(Class bridgeModuleClass);
4444
NSMutableArray<NSString *> *getModulesLoadedWithOldArch(void);
4545

4646
/**
47-
* Experimental.
48-
* Check/set if JSI-bound NativeModule is enabled. By default it's off.
47+
* The New Architecture is enabled by default. These APIs are no-ops and will
48+
* be removed in a future release.
4949
*/
50-
BOOL RCTTurboModuleEnabled(void);
51-
void RCTEnableTurboModule(BOOL enabled);
50+
BOOL RCTTurboModuleEnabled(void)
51+
__attribute__((deprecated("TurboModules are always enabled; this always returns YES (NO in test env).")));
52+
void RCTEnableTurboModule(BOOL enabled)
53+
__attribute__((deprecated("No-op. The New Architecture is enabled by default.")));
5254

5355
#ifndef RCT_REMOVE_LEGACY_MODULE_INTEROP
5456
// Turn on TurboModule interop

packages/react-native/React/Base/RCTBridge.mm

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ void RCTRegisterModule(Class moduleClass)
182182
return RCTDropReactPrefixes(name);
183183
}
184184

185-
static const BOOL turboModuleEnabled = YES;
186185
BOOL RCTTurboModuleEnabled(void)
187186
{
188187
#if RCT_DEBUG
@@ -191,7 +190,7 @@ BOOL RCTTurboModuleEnabled(void)
191190
return NO;
192191
}
193192
#endif
194-
return turboModuleEnabled;
193+
return YES;
195194
}
196195

197196
void RCTEnableTurboModule(BOOL enabled)

0 commit comments

Comments
 (0)