Run Rector

Author: dbellettini

composer.json

@@ -21,7 +21,8 @@
         "phake/phake": "^4.6",
         "phpunit/phpunit": "^12.3",
         "symfony/process": "^7.3",
-        "phpstan/phpstan": "^2.1"
+        "phpstan/phpstan": "^2.1",
+        "rector/rector": "^2.1"
     },
     "replace": {
         "easywelfare/onebip-concurrency": "self.version",

rector.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+    ])
+    // uncomment to reach your current PHP version
+    // ->withPhpSets()
+    ->withTypeCoverageLevel(0)
+    ->withDeadCodeLevel(0)
+    ->withCodeQualityLevel(0);

src/Recruiter/Concurrency/Timeout.php

@@ -30,7 +30,7 @@ private function __construct($microseconds, $waitingFor)
     {
         $this->maximum = $microseconds;
         $this->waitingFor = $waitingFor;
-        $this->afterCheck = function () {
+        $this->afterCheck = function (): void {
         };
     }
 

tests/Recruiter/Concurrency/InProcessRetryTest.php

@@ -25,7 +25,7 @@ protected function setUp(): void
 
     private function exceptionalCounterFactory(string $exceptionClass): \Closure
     {
-        return function () use ($exceptionClass) {
+        return function () use ($exceptionClass): void {
             ++$this->count;
             throw new $exceptionClass();
         };

tests/Recruiter/Concurrency/MongoLockTest.php

@@ -30,7 +30,7 @@ protected function setUp(): void
         $this->clock = \Phake::mock(Clock::class);
 
         $this->slept = [];
-        $this->sleep = function ($amount) {
+        $this->sleep = function ($amount): void {
             $this->slept[] = $amount;
         };
     }
@@ -289,7 +289,7 @@ public function testPropertyBased()
 
                 return true;
             })
-            ->then(function ($sequencesOfSteps) {
+            ->then(function ($sequencesOfSteps): void {
                 $this->lockCollection->drop();
                 $log = "/tmp/mongolock_{$this->iteration}.log";
                 if (file_exists($log)) {

tests/Recruiter/Concurrency/PeriodicalCheckTest.php

@@ -27,11 +27,11 @@ public function testDoesNotPerformTheCheckTooManyTimes()
                 ),
             )
             // ->hook(Listener\collectFrequencies())
-            ->then(function ($startingDate, $period, $deltas) {
+            ->then(function ($startingDate, $period, $deltas): void {
                 $clock = new SettableClock($startingDate);
                 $check = PeriodicalCheck::every($period, $clock);
                 $this->counter = 0;
-                $check->onFire(function () {
+                $check->onFire(function (): void {
                     ++$this->counter;
                 });
                 $check->__invoke();

tests/Recruiter/Concurrency/mongolock.php

@@ -22,7 +22,7 @@
 $uri = getenv('MONGODB_URI') ?: null;
 $lockCollection = new MongoDB\Client($uri)->selectCollection('concurrency-test', 'lock');
 $lock = new MongoLock($lockCollection, 'ilium_gate', $name);
-$log = function ($data) {
+$log = function ($data): void {
     fputcsv(
         STDOUT,
         array_merge(