diff --git a/.github/workflows/code_analysis.yaml b/.github/workflows/code_analysis.yaml index 03c8b7469..6d8c91304 100644 --- a/.github/workflows/code_analysis.yaml +++ b/.github/workflows/code_analysis.yaml @@ -19,10 +19,6 @@ jobs: name: 'Composer Validate' run: composer validate --ansi - - - name: 'Rector' - run: composer rector --ansi - - name: 'Coding Standard' run: composer fix-cs --ansi diff --git a/src/Analyzer/UnusedDefinitionsAnalyzer.php b/src/Analyzer/UnusedDefinitionsAnalyzer.php index f74105fc5..dfceea212 100644 --- a/src/Analyzer/UnusedDefinitionsAnalyzer.php +++ b/src/Analyzer/UnusedDefinitionsAnalyzer.php @@ -16,6 +16,9 @@ use Symfony\Component\Console\Style\SymfonyStyle; use Symfony\Component\Finder\SplFileInfo; +/** + * @see \Rector\Behastan\Tests\Analyzer\UnusedDefinitionsAnalyzer\UnusedDefinitionsAnalyzerTest + */ final readonly class UnusedDefinitionsAnalyzer { /** @@ -43,7 +46,6 @@ public function analyse(array $contextFiles, array $featureFiles): array $this->maskCollectionStatsPrinter->printStats($maskCollection); $featureInstructions = $this->usedInstructionResolver->resolveInstructionsFromFeatureFiles($featureFiles); - $maskProgressBar = $this->symfonyStyle->createProgressBar($maskCollection->count()); $unusedMasks = []; diff --git a/src/DependencyInjection/ContainerFactory.php b/src/DependencyInjection/ContainerFactory.php index 12f6a31ec..4659cfcd2 100644 --- a/src/DependencyInjection/ContainerFactory.php +++ b/src/DependencyInjection/ContainerFactory.php @@ -50,9 +50,15 @@ public function create(): Container return $phpParserFactory->createForHostVersion(); }); + // silence in PHPUnit tests to keep output clear + $consoleOutput = new ConsoleOutput(); + $consoleOutput->setVerbosity( + defined('PHPUNIT_COMPOSER_INSTALL') ? ConsoleOutput::VERBOSITY_QUIET : ConsoleOutput::VERBOSITY_NORMAL + ); + $container->singleton( SymfonyStyle::class, - static fn (): SymfonyStyle => new SymfonyStyle(new ArrayInput([]), new ConsoleOutput()) + static fn (): SymfonyStyle => new SymfonyStyle(new ArrayInput([]), $consoleOutput) ); return $container; diff --git a/stubs/Behat/Behat/Context/Context.php b/stubs/Behat/Behat/Context/Context.php new file mode 100644 index 000000000..f69dc4948 --- /dev/null +++ b/stubs/Behat/Behat/Context/Context.php @@ -0,0 +1,9 @@ +unusedDefinitionsAnalyzer = $this->make(UnusedDefinitionsAnalyzer::class); + } + + public function test(): void + { + $featureFiles = BehatMetafilesFinder::findFeatureFiles([__DIR__ . '/Fixture/Features']); + $this->assertCount(1, $featureFiles); + + $contextFiles = BehatMetafilesFinder::findContextFiles([__DIR__ . '/Fixture/Contexts']); + $this->assertCount(1, $contextFiles); + + $unusedDefinitions = $this->unusedDefinitionsAnalyzer->analyse($contextFiles, $featureFiles); + + $this->assertCount(0, $unusedDefinitions); + } +}