Extensions plugin: Enable accessibility checks and fix remaining a11y issues

[christoph-jerolimov]

The extension plugin has playwright tests that include a bunch of accessibility assertions.

The tests runs runAccessibilityTests from @workspaces/extensions/e2e-tests/utils/accessibility.ts, but failures are ignored at the moment.

1. Remove the options parameter with the skipFailures flag and run the expect statement always.
2. Run the playwright tests via CI=1 yarn test:e2e and list the left over issues.
3. Try to resolve these issues in the code base. When unsure, or not all issues can be removed, create a PR anyway.

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 2:00 PM UTC · Completed 2:03 PM UTC
Commit: 381f36a · View workflow run →

[fullsend-ai-triage]

Triage Summary

Severity: Medium | Category: Feature (enabling enforcement of existing checks)

The extensions plugin has playwright accessibility tests using @axe-core/playwright, but the runAccessibilityTests utility defaults to skipping failures (skipFailures: true). Violations are attached as JSON artifacts but never cause test failures.

Recommended Approach

1. Modify accessibility.ts — Remove the options parameter and the conditional guard so the expect assertion always runs:

   export async function runAccessibilityTests(
     page: Page,
     testInfo: TestInfo,
     attachName = 'accessibility-scan-results.json',
   ) {
     const accessibilityScanResults = await new AxeBuilder({ page })
       .withTags(['wcag2a', 'wcag2aa', 'wcag21a', 'wcag21aa'])
       .analyze();
   
     await testInfo.attach(attachName, {
       body: JSON.stringify(accessibilityScanResults.violations, null, 2),
       contentType: 'application/json',
     });
   
     expect(
       accessibilityScanResults.violations,
       'Accessibility violations found',
     ).toEqual([]);
   }

2. Update callers — Remove any { skipFailures: true } arguments passed to the function.
3. Run CI=1 yarn test:e2e to surface current violations.
4. Fix violations in the extensions plugin components (missing ARIA attributes, color contrast, form labels, etc.).
5. If not all violations can be resolved, submit a PR with fixes applied and document remaining items.

Proposed Test Verification

After removing skipFailures:
- All existing e2e tests calling runAccessibilityTests should pass
- accessibilityScanResults.violations should be an empty array
- JSON attachment should still be generated for reporting
- No WCAG 2.0/2.1 AA violations reported by axe-core

---

Labels: This issue targets the extensions workspace and involves enabling/fixing accessibility test enforcement.

[christoph-jerolimov]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ❌ Failure · Started 2:16 PM UTC · Completed 2:55 PM UTC
Commit: 381f36a · View workflow run →

[christoph-jerolimov]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 4:02 PM UTC · Completed 4:52 PM UTC
Commit: 381f36a · View workflow run →