Lightspeed plugin: Enable accessibility checks and fix remaining a11y issues

[christoph-jerolimov]

The lightspeed plugin has playwright tests that include a bunch of accessibility assertions.

The tests runs runAccessibilityTests from @workspaces/lightspeed/e2e-tests/utils/accessibility.ts, but failures are ignored at the moment.

1. Remove the options parameter with the skipFailures flag and run the expect statement always.
2. Run the playwright tests via CI=1 yarn test:e2e and list the left over issues.
3. Try to resolve these issues in the code base. When unsure, or not all issues can be removed, create a PR anyway.

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 7:16 PM UTC · Completed 7:19 PM UTC
Commit: bf40fcb · View workflow run →

[fullsend-ai-triage]

Triage Summary

This is a well-defined enhancement task to enforce accessibility assertions in the lightspeed plugin's Playwright e2e tests.

Problem: The runAccessibilityTests utility in e2e-tests/utils/accessibility.ts has a skipFailures option that suppresses accessibility assertion failures, meaning a11y regressions go undetected.

Recommended approach:

1. Remove the options parameter with the skipFailures flag from runAccessibilityTests so assertions always run
2. Update all callers to remove the skipFailures argument
3. Run CI=1 yarn test:e2e to surface remaining a11y violations
4. Fix the identified issues (e.g., missing ARIA attributes, contrast issues, missing roles)

Proposed test verification:

After the fix:
- runAccessibilityTests no longer accepts a skipFailures option
- All e2e tests pass with CI=1 yarn test:e2e
- Intentionally introducing an a11y violation (e.g., removing an aria-label)
  causes a test failure, confirming checks are enforced

Severity: Medium — accessibility violations affect users of assistive technologies but the plugin remains functional for other users.

---

Labels: Issue targets the lightspeed workspace and involves enabling/improving test assertions, matching the workspace and enhancement labels.

[christoph-jerolimov]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 11:21 PM UTC · Completed 11:27 PM UTC
Commit: 4866641 · View workflow run →