Scorecard plugin: Remove accessibility violation filter and fix remaining a11y issues

[christoph-jerolimov]

The scorecard insights plugins has playwright tests that include a bunch of accessibility assertions.

The tests runs runAccessibilityTests from @workspaces/scorecard/packages/app-legacy/e2e-tests/utils/accessibility.ts, but some violations was ignored at the moment. They are filtered out.

1. Remove the accessibility violation filter to fail if there is any a11y issue.
2. Run the playwright tests via CI=1 yarn test:e2e and list the left over issues.
3. Try to resolve these issues in the code base. When unsure, or not all issues can be removed, create a PR anyway.

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 7:20 PM UTC · Completed 7:22 PM UTC
Commit: bf40fcb · View workflow run →

[fullsend-ai-triage]

Triage Summary

This is a well-defined accessibility improvement task for the scorecard plugin.

Problem: The runAccessibilityTests utility in accessibility.ts currently filters out button-name axe-core violations, suppressing real accessibility issues rather than fixing them.

Current filter (to remove):

const filteredViolations = accessibilityScanResults.violations.filter(
  v => v.id !== 'button-name',
);

Recommended approach:

1. Remove the filteredViolations logic and assert directly on accessibilityScanResults.violations
2. Run CI=1 yarn test:e2e to surface the violations
3. Fix each failing component — likely by adding aria-label attributes to icon-only buttons
4. Buttons with tooltips should still have accessible names independent of the tooltip

Proposed test verification:

After removing the filter, all existing e2e tests calling
runAccessibilityTests should pass with zero violations.
Verify that icon-only buttons now have descriptive aria-label
attributes matching their tooltip text.

Severity: Medium — this is a proactive accessibility compliance improvement, not a regression.

---

Labels: Scorecard workspace plugin with accessibility/enhancement focus.

[christoph-jerolimov]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 11:18 PM UTC · Completed 12:08 AM UTC
Commit: 4866641 · View workflow run →