Theme plugin: Enable accessibility checks and fix remaining a11y issues

[christoph-jerolimov]

The theme plugin has playwright tests that include a bunch of accessibility assertions.

The tests runs runAccessibilityTests from @workspaces/theme/packages/app-legacy/e2e-tests/utils/acessibility.ts and @workspaces/theme/packages/app/e2e-tests/utils/acessibility.ts, but failures are ignored at the moment.

1. Remove the skipViolationsAssert attribute from the options parameter of runAccessibilityTests.
2. Run the expect statement always to check the validations.
3. Run the playwright tests via CI=1 yarn test:e2e and list the left over issues.
4. Try to resolve these issues in the code base. When unsure, or not all issues can be removed, create a PR anyway.

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 7:22 PM UTC · Completed 7:24 PM UTC
Commit: bf40fcb · View workflow run →

[fullsend-ai-triage]

Triage Summary

Severity: Medium · Category: Feature/Enhancement

Problem

The theme plugin's playwright e2e tests include accessibility assertions via runAccessibilityTests, but the skipViolationsAssert option suppresses failures, meaning a11y violations are not caught in CI.

Recommended Approach

1. Remove the skipViolationsAssert attribute from the options parameter of runAccessibilityTests in both:
   • packages/app-legacy/e2e-tests/utils/acessibility.ts
   • packages/app/e2e-tests/utils/acessibility.ts
2. Ensure the expect/assert statement runs unconditionally.
3. Run CI=1 yarn test:e2e in the theme workspace to identify remaining violations.
4. Fix identified a11y issues in the codebase.
5. If not all issues can be resolved, submit a PR with fixes and document remaining items.

Proposed Test Verification

After removing skipViolationsAssert:
- Existing playwright a11y tests should fail if violations exist
- Tests should pass after a11y fixes are applied
- Verify no regressions in theme rendering/functionality
- Check that decorative/non-interactive elements have appropriate ARIA attributes to avoid false positives

No duplicate issues or blocking PRs were found. This issue has clear, actionable steps and is ready for implementation.

---

Labels: This issue targets the theme workspace plugin and is an enhancement to enable accessibility checks.

[christoph-jerolimov]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 11:19 PM UTC · Completed 11:35 PM UTC
Commit: 4866641 · View workflow run →