diff --git a/workspaces/scorecard/packages/app-legacy/e2e-tests/utils/accessibility.ts b/workspaces/scorecard/packages/app-legacy/e2e-tests/utils/accessibility.ts index bb6865f769..5eed4135c2 100644 --- a/workspaces/scorecard/packages/app-legacy/e2e-tests/utils/accessibility.ts +++ b/workspaces/scorecard/packages/app-legacy/e2e-tests/utils/accessibility.ts @@ -41,10 +41,8 @@ export async function runAccessibilityTests( contentType: 'application/json', }); - // Ignore button-name for icon-only buttons that have a tooltip (e.g. scorecard "Last updated" info icon) - const filteredViolations = accessibilityScanResults.violations.filter( - v => v.id !== 'button-name', - ); - - expect(filteredViolations, 'Accessibility violations found').toEqual([]); + expect( + accessibilityScanResults.violations, + 'Accessibility violations found', + ).toEqual([]); } diff --git a/workspaces/scorecard/plugins/scorecard/report-alpha.api.md b/workspaces/scorecard/plugins/scorecard/report-alpha.api.md index 297dde95a2..9b1e63d0e4 100644 --- a/workspaces/scorecard/plugins/scorecard/report-alpha.api.md +++ b/workspaces/scorecard/plugins/scorecard/report-alpha.api.md @@ -25,8 +25,8 @@ const _default: OverridableFrontendPlugin< { root: RouteRef; drillDown: RouteRef<{ - aggregationId: string; metricId: string; + aggregationId: string; }>; }, {}, @@ -59,7 +59,6 @@ const _default: OverridableFrontendPlugin< }; output: | ExtensionDataRef - | ExtensionDataRef | ExtensionDataRef< RouteRef_2, 'core.routing.ref', @@ -67,6 +66,7 @@ const _default: OverridableFrontendPlugin< optional: true; } > + | ExtensionDataRef | ExtensionDataRef< string, 'core.title', @@ -197,6 +197,7 @@ export const scorecardTranslationRef: TranslationRef< readonly 'metric.filecheck.description': string; readonly 'metric.lastUpdated': string; readonly 'metric.lastUpdatedNotAvailable': string; + readonly 'metric.lastUpdatedInfoButton': string; readonly 'metric.someEntitiesNotReportingValues': string; readonly 'metric.averageCenterTooltipTotalLabel': string; readonly 'metric.averageCenterTooltipMaxLabel': string; diff --git a/workspaces/scorecard/plugins/scorecard/report.api.md b/workspaces/scorecard/plugins/scorecard/report.api.md index 31909b82b4..7e258603f5 100644 --- a/workspaces/scorecard/plugins/scorecard/report.api.md +++ b/workspaces/scorecard/plugins/scorecard/report.api.md @@ -97,6 +97,7 @@ export const scorecardTranslationRef: TranslationRef< readonly 'metric.filecheck.description': string; readonly 'metric.lastUpdated': string; readonly 'metric.lastUpdatedNotAvailable': string; + readonly 'metric.lastUpdatedInfoButton': string; readonly 'metric.someEntitiesNotReportingValues': string; readonly 'metric.averageCenterTooltipTotalLabel': string; readonly 'metric.averageCenterTooltipMaxLabel': string; diff --git a/workspaces/scorecard/plugins/scorecard/src/components/AggregatedMetricCards/components/CardInfoButton.tsx b/workspaces/scorecard/plugins/scorecard/src/components/AggregatedMetricCards/components/CardInfoButton.tsx index 2f5f8cede4..fa7bac96f8 100644 --- a/workspaces/scorecard/plugins/scorecard/src/components/AggregatedMetricCards/components/CardInfoButton.tsx +++ b/workspaces/scorecard/plugins/scorecard/src/components/AggregatedMetricCards/components/CardInfoButton.tsx @@ -56,7 +56,10 @@ export const CardInfoButton = ({ timestamp }: { timestamp: string }) => { }, }} > - + diff --git a/workspaces/scorecard/plugins/scorecard/src/translations/de.ts b/workspaces/scorecard/plugins/scorecard/src/translations/de.ts index db35af36e4..ef74cd0c54 100644 --- a/workspaces/scorecard/plugins/scorecard/src/translations/de.ts +++ b/workspaces/scorecard/plugins/scorecard/src/translations/de.ts @@ -98,6 +98,7 @@ const scorecardTranslationDe = createTranslationMessages({ 'metric.jira.open_issues.title': 'Jira-Tickets öffnen und blockieren', 'metric.lastUpdated': 'Letzte Aktualisierung: {{timestamp}}', 'metric.lastUpdatedNotAvailable': 'Letzte Aktualisierung: Nicht verfügbar', + 'metric.lastUpdatedInfoButton': 'Informationen zur letzten Aktualisierung', 'metric.someEntitiesNotReportingValues': 'Einige Organisationen melden keine Werte, die sich auf diese Kennzahl beziehen.', 'metric.sonarqube.code_coverage.description': diff --git a/workspaces/scorecard/plugins/scorecard/src/translations/es.ts b/workspaces/scorecard/plugins/scorecard/src/translations/es.ts index a809361ae5..c46347150f 100644 --- a/workspaces/scorecard/plugins/scorecard/src/translations/es.ts +++ b/workspaces/scorecard/plugins/scorecard/src/translations/es.ts @@ -99,6 +99,7 @@ const scorecardTranslationEs = createTranslationMessages({ 'metric.jira.open_issues.title': 'Tickets de bloqueo abiertos en Jira', 'metric.lastUpdated': 'Última actualización: {{timestamp}}', 'metric.lastUpdatedNotAvailable': 'Última actualización: no disponible', + 'metric.lastUpdatedInfoButton': 'Información de última actualización', 'metric.someEntitiesNotReportingValues': 'Algunas entidades no informan valores relacionados con esta métrica.', 'metric.sonarqube.code_coverage.description': diff --git a/workspaces/scorecard/plugins/scorecard/src/translations/fr.ts b/workspaces/scorecard/plugins/scorecard/src/translations/fr.ts index 7e94ac5e8a..21ea0ad09b 100644 --- a/workspaces/scorecard/plugins/scorecard/src/translations/fr.ts +++ b/workspaces/scorecard/plugins/scorecard/src/translations/fr.ts @@ -100,6 +100,7 @@ const scorecardTranslationFr = createTranslationMessages({ 'metric.jira.open_issues.title': 'Tickets de blocage ouverts Jira', 'metric.lastUpdated': 'Dernière mise à jour : {{timestamp}}', 'metric.lastUpdatedNotAvailable': 'Dernière mise à jour : Non disponible', + 'metric.lastUpdatedInfoButton': 'Informations sur la dernière mise à jour', 'metric.someEntitiesNotReportingValues': 'Certaines entités ne communiquent pas les valeurs relatives à cet indicateur.', 'metric.sonarqube.code_coverage.description': diff --git a/workspaces/scorecard/plugins/scorecard/src/translations/it.ts b/workspaces/scorecard/plugins/scorecard/src/translations/it.ts index 242ab68d98..055faf5189 100644 --- a/workspaces/scorecard/plugins/scorecard/src/translations/it.ts +++ b/workspaces/scorecard/plugins/scorecard/src/translations/it.ts @@ -100,6 +100,7 @@ const scorecardTranslationIt = createTranslationMessages({ 'metric.jira.open_issues.title': 'Ticket di blocco aperti in Jira', 'metric.lastUpdated': 'Ultimo aggiornamento: {{timestamp}}', 'metric.lastUpdatedNotAvailable': 'Ultimo aggiornamento: non disponibile', + 'metric.lastUpdatedInfoButton': "Informazioni sull'ultimo aggiornamento", 'metric.someEntitiesNotReportingValues': 'Alcune entità non comunicano i valori relativi a questa metrica.', 'metric.sonarqube.code_coverage.description': diff --git a/workspaces/scorecard/plugins/scorecard/src/translations/ja.ts b/workspaces/scorecard/plugins/scorecard/src/translations/ja.ts index aaf9571662..45193ec7a3 100644 --- a/workspaces/scorecard/plugins/scorecard/src/translations/ja.ts +++ b/workspaces/scorecard/plugins/scorecard/src/translations/ja.ts @@ -100,6 +100,7 @@ const scorecardTranslationJa = createTranslationMessages({ 'Jira のオープン状態の進行を妨げているチケット', 'metric.lastUpdated': '最終更新: {{timestamp}}', 'metric.lastUpdatedNotAvailable': '最終更新: 利用不可', + 'metric.lastUpdatedInfoButton': '最終更新情報', 'metric.someEntitiesNotReportingValues': 'このメトリクスに関連する値を報告していないエンティティーがあります。', 'metric.sonarqube.code_coverage.description': diff --git a/workspaces/scorecard/plugins/scorecard/src/translations/ref.ts b/workspaces/scorecard/plugins/scorecard/src/translations/ref.ts index d76080342c..9dfcd9be1c 100644 --- a/workspaces/scorecard/plugins/scorecard/src/translations/ref.ts +++ b/workspaces/scorecard/plugins/scorecard/src/translations/ref.ts @@ -146,6 +146,7 @@ export const scorecardMessages = { }, lastUpdated: 'Last updated: {{timestamp}}', lastUpdatedNotAvailable: 'Last updated: Not available', + lastUpdatedInfoButton: 'Last updated info', someEntitiesNotReportingValues: 'Some entities are not reporting values related to this metric.', averageCenterTooltipTotalLabel: 'Total score',