Skip to content

Commit 3bcdbf1

Browse files
committed
fix: turn off unknown properties and stroke svg attributes
1 parent feea795 commit 3bcdbf1

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

packages/browser-sdk/eslint.config.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ module.exports = [
1414
},
1515
},
1616
rules: {
17-
"react/no-unknown-property": ["error", { ignore: ["class"] }],
17+
// Ignore React attributes that are not valid in Preact.
18+
// Alternatively, we could use the preact/compat alias or turn off the rule.
19+
"react/no-unknown-property": ["off"],
1820
},
1921
},
2022
{ ignores: ["dist/", "example/"] },

packages/browser-sdk/src/feedback/ui/RadialProgress.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ export const RadialProgress: FunctionComponent<{
1616
cy={radius + stroke}
1717
fill="transparent"
1818
r={radius}
19-
strokeDasharray={circumference}
20-
strokeDashoffset={filled}
21-
strokeWidth={stroke}
19+
stroke-dasharray={circumference}
20+
stroke-dashoffset={filled}
21+
stroke-width={stroke}
2222
transform={`rotate(-90) translate(-${radius * 2 + stroke * 2} 0)`}
2323
/>
2424
</svg>

packages/browser-sdk/src/feedback/ui/StarRating.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ const Score = ({
146146
ref={refs.setReference}
147147
aria-label={score.getLabel(t)}
148148
class="button"
149-
htmlFor={`bucket-feedback-score-${score.value}`}
149+
for={`bucket-feedback-score-${score.value}`}
150150
style={{ color: score.color }}
151151
>
152152
<div

0 commit comments

Comments
 (0)