Skip to content

Commit 50a3677

Browse files
committed
working on tests
1 parent 56550b0 commit 50a3677

4 files changed

Lines changed: 23 additions & 2 deletions

File tree

packages/browser-sdk/src/client.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -775,10 +775,10 @@ export class BucketClient {
775775
},
776776
isEnabledOverride: this.featuresClient.getFeatureOverride(key),
777777
setIsEnabledOverride(isEnabled: boolean | null) {
778-
fClient.setFeatureOverride(key, isEnabled);
778+
self.featuresClient.setFeatureOverride(key, isEnabled);
779779
},
780780
setInUse(inUse: boolean) {
781-
fClient.setInUse(key, inUse);
781+
self.featuresClient.setInUse(key, inUse);
782782
},
783783
};
784784
}

packages/browser-sdk/test/features.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ describe("FeaturesClient", () => {
265265
key: "featureB",
266266
targetingVersion: 1,
267267
isEnabledOverride: null,
268+
inUse: false,
268269
} satisfies RawFeature,
269270
});
270271

@@ -304,6 +305,7 @@ describe("FeaturesClient", () => {
304305
targetingVersion: 1,
305306
key: "featureA",
306307
isEnabledOverride: null,
308+
inUse: false,
307309
} satisfies RawFeature,
308310
}),
309311
);

packages/browser-sdk/test/mocks/handlers.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export const featuresResult = Object.entries(featureResponse.features).reduce(
3636
...feature!,
3737
config: feature.config,
3838
isEnabledOverride: null,
39+
inUse: false,
3940
};
4041
return acc;
4142
},

packages/browser-sdk/test/usage.test.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ describe("usage", () => {
8080
track: expect.any(Function),
8181
requestFeedback: expect.any(Function),
8282
config: { key: undefined, payload: undefined },
83+
isEnabledOverride: null,
84+
setInUse: expect.any(Function),
85+
setIsEnabledOverride: expect.any(Function),
8386
});
8487
});
8588

@@ -413,6 +416,9 @@ describe(`sends "check" events `, () => {
413416
config: { key: undefined, payload: undefined },
414417
track: expect.any(Function),
415418
requestFeedback: expect.any(Function),
419+
isEnabledOverride: null,
420+
setInUse: expect.any(Function),
421+
setIsEnabledOverride: expect.any(Function),
416422
});
417423

418424
expect(client.getFeature("featureB")).toStrictEqual({
@@ -426,13 +432,19 @@ describe(`sends "check" events `, () => {
426432
},
427433
track: expect.any(Function),
428434
requestFeedback: expect.any(Function),
435+
isEnabledOverride: null,
436+
setInUse: expect.any(Function),
437+
setIsEnabledOverride: expect.any(Function),
429438
});
430439

431440
expect(client.getFeature("featureC")).toStrictEqual({
432441
isEnabled: false,
433442
config: { key: undefined, payload: undefined },
434443
track: expect.any(Function),
435444
requestFeedback: expect.any(Function),
445+
isEnabledOverride: null,
446+
setInUse: expect.any(Function),
447+
setIsEnabledOverride: expect.any(Function),
436448
});
437449
});
438450

@@ -564,9 +576,12 @@ describe(`sends "check" events `, () => {
564576
const featureId1 = client.getFeature("featureId1");
565577
expect(featureId1).toStrictEqual({
566578
isEnabled: false,
579+
isEnabledOverride: null,
567580
track: expect.any(Function),
568581
requestFeedback: expect.any(Function),
569582
config: { key: undefined, payload: undefined },
583+
setInUse: expect.any(Function),
584+
setIsEnabledOverride: expect.any(Function),
570585
});
571586

572587
vi.spyOn(client, "track");
@@ -586,6 +601,9 @@ describe(`sends "check" events `, () => {
586601
track: expect.any(Function),
587602
requestFeedback: expect.any(Function),
588603
config: { key: undefined, payload: undefined },
604+
isEnabledOverride: null,
605+
setIsEnabledOverride: expect.any(Function),
606+
setInUse: expect.any(Function),
589607
});
590608

591609
vi.spyOn(client, "requestFeedback");

0 commit comments

Comments
 (0)