fix(flag-evaluation) Revert async API (#392)

In #384 I made the interface async, that is no longer needed.

Author: roncohen

packages/flag-evaluation/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bucketco/flag-evaluation",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "license": "MIT",
   "repository": {
     "type": "git",

packages/flag-evaluation/src/index.ts

@@ -259,7 +259,7 @@ export function unflattenJSON(data: Record<string, any>): Record<string, any> {
  * @param {string} hashInput - The input string used to generate the hash.
  * @return {number} A number between 0 and 100000 derived from the hash of the input string.
  */
-export async function hashInt(hashInput: string): Promise<number> {
+export function hashInt(hashInput: string): number {
   // 1. hash the key and the partial rollout attribute
   // 2. take 20 bits from the hash and divide by 2^20 - 1 to get a number between 0 and 1
   // 3. multiply by 100000 to get a number between 0 and 100000 and compare it to the threshold
@@ -344,11 +344,11 @@ export function evaluate(
   }
 }
 
-async function evaluateRecursively(
+function evaluateRecursively(
   filter: RuleFilter,
   context: Record<string, string>,
   missingContextFieldsSet: Set<string>,
-): Promise<boolean> {
+): boolean {
   switch (filter.type) {
     case "constant":
       return filter.value;
@@ -369,38 +369,30 @@ async function evaluateRecursively(
         return false;
       }
 
-      const hashVal = await hashInt(
+      const hashVal = hashInt(
         `${filter.key}.${context[filter.partialRolloutAttribute]}`,
       );
 
       return hashVal < filter.partialRolloutThreshold;
     }
-    case "group": {
-      const isAnd = filter.operator === "and";
-      let result = isAnd;
-      for (const current of filter.filters) {
-        // short-circuit if we know the result already
-        // could be simplified to isAnd !== result, but this is more readable
-        if ((isAnd && !result) || (!isAnd && result)) {
-          return result;
+    case "group":
+      return filter.filters.reduce((acc, current) => {
+        if (filter.operator === "and") {
+          return (
+            acc &&
+            evaluateRecursively(current, context, missingContextFieldsSet)
+          );
         }
-
-        const newRes = await evaluateRecursively(
-          current,
-          context,
-          missingContextFieldsSet,
+        return (
+          acc || evaluateRecursively(current, context, missingContextFieldsSet)
         );
-
-        result = isAnd ? result && newRes : result || newRes;
-      }
-      return result;
-    }
+      }, filter.operator === "and");
     case "negation":
-      return !(await evaluateRecursively(
+      return !evaluateRecursively(
         filter.filter,
         context,
         missingContextFieldsSet,
-      ));
+      );
     default:
       return false;
   }
@@ -442,18 +434,16 @@ export interface EvaluationResult<T extends RuleValue> {
   missingContextFields?: string[];
 }
 
-export async function evaluateFeatureRules<T extends RuleValue>({
+export function evaluateFeatureRules<T extends RuleValue>({
   context,
   featureKey,
   rules,
-}: EvaluationParams<T>): Promise<EvaluationResult<T>> {
+}: EvaluationParams<T>): EvaluationResult<T> {
   const flatContext = flattenJSON(context);
   const missingContextFieldsSet = new Set<string>();
 
-  const ruleEvaluationResults = await Promise.all(
-    rules.map((rule) =>
-      evaluateRecursively(rule.filter, flatContext, missingContextFieldsSet),
-    ),
+  const ruleEvaluationResults = rules.map((rule) =>
+    evaluateRecursively(rule.filter, flatContext, missingContextFieldsSet),
   );
 
   const missingContextFields = Array.from(missingContextFieldsSet);

packages/flag-evaluation/test/index.test.ts

@@ -38,7 +38,7 @@ const feature = {
 
 describe("evaluate feature targeting integration ", () => {
   it("evaluates all kinds of filters", async () => {
-    const res = await evaluateFeatureRules({
+    const res = evaluateFeatureRules({
       featureKey: "feature",
       rules: [
         {
@@ -109,7 +109,7 @@ describe("evaluate feature targeting integration ", () => {
   });
 
   it("evaluates flag when there's no matching rule", async () => {
-    const res = await evaluateFeatureRules({
+    const res = evaluateFeatureRules({
       ...feature,
       context: {
         company: {
@@ -137,7 +137,7 @@ describe("evaluate feature targeting integration ", () => {
       },
     };
 
-    const res = await evaluateFeatureRules({
+    const res = evaluateFeatureRules({
       ...feature,
       context,
     });
@@ -155,7 +155,7 @@ describe("evaluate feature targeting integration ", () => {
   });
 
   it("evaluates flag with missing values", async () => {
-    const res = await evaluateFeatureRules({
+    const res = evaluateFeatureRules({
       featureKey: "feature",
       rules: [
         {
@@ -198,7 +198,7 @@ describe("evaluate feature targeting integration ", () => {
   });
 
   it("returns list of missing context keys ", async () => {
-    const res = await evaluateFeatureRules({
+    const res = evaluateFeatureRules({
       ...feature,
       context: {},
     });
@@ -214,7 +214,7 @@ describe("evaluate feature targeting integration ", () => {
   });
 
   it("fails evaluation and includes key in missing keys when rollout attribute is missing from context", async () => {
-    const res = await evaluateFeatureRules({
+    const res = evaluateFeatureRules({
       featureKey: "myfeature",
       rules: [
         {
@@ -352,8 +352,8 @@ describe("rollout hash", () => {
   ] as const;
 
   for (const [input, expected] of tests) {
-    it(`evaluates '${input}' = ${expected}`, async () => {
-      const res = await hashInt(input);
+    it(`evaluates '${input}' = ${expected}`, () => {
+      const res = hashInt(input);
       expect(res).toEqual(expected);
     });
   }

yarn.lock

@@ -545,14 +545,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@bucketco/flag-evaluation@npm:~0.1.0":
-  version: 0.1.0
-  resolution: "@bucketco/flag-evaluation@npm:0.1.0"
-  checksum: 10c0/a5d747962d43ce12b194735e92524a576edac9e9ad53c425b4a517123ca9918d3001891cd212f178b7cf6b235c79aa5cfa3942e162187da056c2ae1d5230a984
-  languageName: node
-  linkType: hard
-
-"@bucketco/flag-evaluation@workspace:packages/flag-evaluation":
+"@bucketco/flag-evaluation@npm:~0.1.0, @bucketco/flag-evaluation@workspace:packages/flag-evaluation":
   version: 0.0.0-use.local
   resolution: "@bucketco/flag-evaluation@workspace:packages/flag-evaluation"
   dependencies: