add comment

roncohen · roncohen · commit bc1ec183eab7 · 2025-03-23T11:23:39.000+01:00
diff --git a/packages/flag-evaluation/src/index.ts b/packages/flag-evaluation/src/index.ts
@@ -387,6 +387,7 @@ async function evaluateRecursively(
       let result = isAnd;
       for (const current of filter.filters) {
         // short-circuit if we know the result already
+        // could be simplified to isAnd !== result, but this is more readable
         if ((isAnd && !result) || (!isAnd && result)) {
           return result;
         }

Original file line number	Diff line number	Diff line change
`@@ -387,6 +387,7 @@ async function evaluateRecursively(`
`387`	`387`	`let result = isAnd;`
`388`	`388`	`for (const current of filter.filters) {`
`389`	`389`	`// short-circuit if we know the result already`
	`390`	`+ // could be simplified to isAnd !== result, but this is more readable`
`390`	`391`	`if ((isAnd && !result) \|\| (!isAnd && result)) {`
`391`	`392`	`return result;`
`392`	`393`	`}`