Skip to content

Commit d3370c8

Browse files
pavkamroncohen
authored andcommitted
chore(open-feature): small PR comments (#332)
Update variable names in HuddleFeature component to enhance readability: - Rename 'provider' to 'huddleMeetingProvider' - Simplify useObjectFlagDetails configuration
1 parent 8947d59 commit d3370c8

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

packages/openfeature-browser-provider/example/app/featureManagement.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export async function initOpenFeature() {
2222
publishableKey,
2323
fallbackFeatures: {
2424
huddle: {
25-
key: "zoom",
25+
key: "zoom", // huddleMeetingProvider
2626
payload: {
2727
joinUrl: "https://zoom.us/join",
2828
},

packages/openfeature-browser-provider/example/components/HuddleFeature.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,10 @@ const featureKey = "huddle";
1111

1212
export const HuddleFeature = () => {
1313
const isEnabled = useBooleanFlagValue(featureKey, false);
14-
const { variant: provider, value: config } = useObjectFlagDetails(
15-
featureKey,
16-
{
14+
const { variant: huddleMeetingProvider, value: config } =
15+
useObjectFlagDetails(featureKey, {
1716
joinUrl: "https://zoom.us/join",
18-
},
19-
);
17+
});
2018

2119
return (
2220
<div className="border border-gray-300 p-6 rounded-xl dark:border-neutral-800 dark:bg-zinc-800/30">
@@ -25,7 +23,7 @@ export const HuddleFeature = () => {
2523
<code className="font-mono font-bold">{JSON.stringify(isEnabled)}</code>
2624
</pre>
2725
<h3 className="text-xl mb-4">
28-
Huddle using <strong>{provider}</strong>:
26+
Huddle using <strong>{huddleMeetingProvider}</strong>:
2927
</h3>
3028
<pre>
3129
<code className="font-mono font-bold">

0 commit comments

Comments
 (0)