bring back the "all" parameter for tests

Author: roncohen

packages/node-sdk/src/rate-limiter.ts

@@ -14,9 +14,13 @@ export function newRateLimiter(windowSizeMs: number) {
     "windowSizeMs must be greater than 0",
   );
 
-  const lastAllowedTimestampsByKey: { [key: string]: number } = {};
+  let lastAllowedTimestampsByKey: { [key: string]: number } = {};
+
+  function clearStale(all: boolean = false): void {
+    if (all) {
+      lastAllowedTimestampsByKey = {};
+    }
 
-  function clearStale(): void {
     const expireBeforeTimestamp = Date.now() - windowSizeMs;
     const keys = Object.keys(lastAllowedTimestampsByKey);
 

packages/node-sdk/test/client.test.ts

@@ -447,7 +447,7 @@ describe("BucketClient", () => {
 
     beforeEach(() => {
       vi.mocked(httpClient.post).mockResolvedValue({ body: { success: true } });
-      client["rateLimiter"].clear(true);
+      client["rateLimiter"].clearStale(true);
     });
 
     it("should return a new client instance with the `user`, `company` and `other` set", async () => {
@@ -568,7 +568,7 @@ describe("BucketClient", () => {
     const client = new BucketClient(validOptions);
 
     beforeEach(() => {
-      client["rateLimiter"].clear(true);
+      client["rateLimiter"].clearStale(true);
     });
 
     // try with both string and number IDs
@@ -653,7 +653,7 @@ describe("BucketClient", () => {
     const client = new BucketClient(validOptions);
 
     beforeEach(() => {
-      client["rateLimiter"].clear(true);
+      client["rateLimiter"].clearStale(true);
     });
 
     test.each([
@@ -747,7 +747,7 @@ describe("BucketClient", () => {
     const client = new BucketClient(validOptions);
 
     beforeEach(() => {
-      client["rateLimiter"].clear(true);
+      client["rateLimiter"].clearStale(true);
     });
 
     test.each([
@@ -1411,7 +1411,7 @@ describe("BucketClient", () => {
         },
       );
 
-      client["rateLimiter"].clear(true);
+      client["rateLimiter"].clearStale(true);
 
       httpClient.post.mockResolvedValue({
         ok: true,
@@ -2449,7 +2449,7 @@ describe("BoundBucketClient", () => {
     await client.flush();
 
     vi.mocked(httpClient.post).mockClear();
-    client["rateLimiter"].clear(true);
+    client["rateLimiter"].clearStale(true);
   });
 
   it("should create a client instance", () => {