src/Resend.php lacks a namespace declaration

[ara303]

Resend.php doesn't have a namespace declaration which means Mozart can't automatically isolate dependencies.

The solution I went with

To save you the effort of reading this: You should just use Strauss if you're also having this problem.

---

For context, this library is used in Send Emails With Resend, a WordPress plugin that lets me use Resend for all transactional emails on WordPress sites. Unfortunately, a different WordPress plugin (WPForms) bundles with it an older version of PSR-3 which caused conflicts with the Resend WP plugin. I wanted to fix this by contributing a PR to the Resend plugin that uses namespaced dependencies, but Mozart can't overwrite the namespace if there isn't one to begin with here.

I'm happy to contribute a PR with the fix but thought you might want an issue opened first.

I believe it's just as simple as changing Resend.php like so.

At the start of the file:

namespace Resend;

At the end, to ensure existing implementations referencing \Resend\<name> would still work:

class_alias(\Resend\Resend::class, 'Resend');

Thank you for your time and even more so for this library. Resend's the best transactional email service I've used for TS/JS projects, and I have a big interest in it also being as useable for PHP projects.

[jayanratna]

Hey @ara303, apologies for the delay in responding to this issue.

I definitely think adding a namespace is a good idea. Though I had a question for you regarding the class_alias. Would we still need that with the existing files array config in the Composer autoload section? Currently it's possible to use the Resend class without a namespace because of this global behaviour.

I've also been thinking about aligning the PHP SDK with Node.js SDK where you would do:

$resend = new Resend(...);

Instead of the existing Resend::client(...) static method.

Keen to hear your thoughts.

[ara303]

All good. I'm honestly excited to contribute.

For context, when debugging a WordPress plugin I ultimately concluded I had to isolate its Composer dependencies by using a prefixed namespace to avoid conflicts with other plugins requiring the same dependencies but different versions. All the versions tried to coexist in the global namespace, causing fatal errors.

Based on the wide variety of solutions to this, Mozart, PHP-Scoper, Strauss, Impostor, etc., it's safe to say it's a common problem.

Regarding the files array, you make a good point I hadn't considered. I think the isolation tool I ultimately went with, Strauss, has the answer:

• A generated autoload.php to include in your project (analogous to Composer's vendor/autoload.php)
• Handles files autoloaders – and any autoloaders that Composer itself recognises, since Strauss uses Composer's own tooling to parse the packages

(I was ultimately unable to use Mozart for other reasons involving incompatibility with certain PSR-4 modules.)

Easy way

We could simply amend the readme with a section on dependency isolation, say anything except Strauss doesn't work, and call it a day. No code changes. 😁

Another way

As per your readme, this is inspired by OpenAI's PHP API. From studying that code, I can see it:

1. Exposes a global namespace of OpenAI, and
2. Allows for that namespace to overwritten - see Client.php or Factory.php.

Updated: I was naive and misunderstood how namespace overwriting works. OAI's client is good but I've since realised it actually has the same problem I wanted to work around here.

I'm happy to help however I can, if you do want to rewrite to align this closer to the current Node.js SDK - but wouldn't that introduce breaking changes? I sort of wanted to add something that doesn't, if possible.

I got stumped and asked Claude. It told me my initial idea to namespace all files and provide a class_alias shim was the right solution.

See my fork for my proposed solution. I'd be delighted to turn it into a PR for merging here, if you like what you read.

It's like what I first suggested but more thorough. By adding a new file that shims backward compatibility into Composer's autoload->files function, existing uses of the global Resend namespace works and isolation tools like Mozart and PHP-Scoper recognise the namespace declarations and class_alias() use and overwrite them as appropriate.

To confirm and for peace of mind (primarily my own), I've created and ran some "real world" test cases. The readme explains in depth, but in summary: it just kinda works. 🥳

Please let me know what you think. This is my first time, ever, doing SDK work and I could totally have things wrong. 😅

[ara303]

Since this has been converted to a discussion, I thought I'd add what I've learned since so it can help others.

My solution was to use Strauss, which just works.

Personally, I think SDK code should have a prefixed namespace that's deeper than just Resend, but understand there may be other reasons which mean you want it to exist globally under just one name.

I proposed a fix which achieves both by prefixing the current global namespace, making it Resend\Resend. It accommodates existing use with a class alias so Resend still works alone. I also tested it.

In summary, your current approach is "isolate-able" as long as the right tool is used. Change is not necessarily needed right now. Feel free to close this discussion.