BAPI-14373: Issue with Banner Ethos API Extensibility WRITE SQL (used for POST, PUT or DELETE) is being called on QAPI request

Author: bbellsct

RELEASE-NOTES.md

@@ -1,5 +1,6 @@
 #1.7.0
 * Add setting overrideVersionRangeMediaType=true to allow override of a whole digit representation version number with the highest semantic version where the major version matches. This is in support of version ranges that facilitate easier caller adoption of non-breaking API changes. This feature requires an ApiVersionParser to be configured. 
+* Correct extensibility to not execute WRITE SQL if the request is a POST /qapi request (this represents a query by post read-only request). 
 
 #1.6.0
 * Add support for specifying optional metadata at the representation level of a resource definition.

grails-app/controllers/net/hedtech/restfulapi/RestfulApiController.groovy

@@ -397,6 +397,9 @@ class RestfulApiController {
                     }
                     holder.addHeader(pageOffsetHeader, requestParams.offset ? requestParams?.offset : 0)
                     holder.addHeader(pageMaxHeader, requestParams.max ? requestParams?.max : result.size())
+                    if (request.method == "POST") {
+                        holder.isQapi = true
+                    }
                     renderSuccessResponse( holder, 'default.rest.list.message' )
                 }
             }
@@ -745,7 +748,7 @@ class RestfulApiController {
             // optional: perform content extension post representation
             if (restContentExtensions && isExtensibleContent(content, contentType)) {
                 log.trace("Extending content for resource=$params.pluralizedResourceName with contentType=$contentType")
-                def result = restContentExtensions.applyExtensions(params.pluralizedResourceName, request, params, content)
+                def result = restContentExtensions.applyExtensions(params.pluralizedResourceName, request, params, content, responseHolder.isQapi)
                 if (result.extensionsApplied) {
                     content = result.content
                 }

src/groovy/net/hedtech/restfulapi/ContentExtensions.groovy

@@ -1,5 +1,5 @@
 /* ***************************************************************************
- * Copyright 2017 Ellucian Company L.P. and its affiliates.
+ * Copyright 2017-2018 Ellucian Company L.P. and its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,6 +27,6 @@ interface ContentExtensions {
     /**
      * Apply extensions to content.
      **/
-    def ContentExtensionResult applyExtensions(String resourceName, def request, Map requestParams, def content) throws Throwable
+    def ContentExtensionResult applyExtensions(String resourceName, def request, Map requestParams, def content, def isQapi) throws Throwable
 
 }

src/groovy/net/hedtech/restfulapi/ResponseHolder.groovy

@@ -1,5 +1,5 @@
 /* ***************************************************************************
- * Copyright 2013 Ellucian Company L.P. and its affiliates.
+ * Copyright 2013-2018 Ellucian Company L.P. and its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@ class ResponseHolder {
     Object data
     def headers = [:]
     def message
+    def isQapi = false
 
     void addHeader( String name, Object value ) {
         if (!headers[name]) {