Merge pull request #91 from retejs/new-linter

fix: update cli and fix linting errors

Author: Ni55aN

.eslintrc

@@ -4,3 +4,6 @@ node_modules
 npm-debug.log
 dist
 docs
+/coverage
+.rete-cli
+.sonar

.gitignore

@@ -0,0 +1,14 @@
+import tseslint from 'typescript-eslint';
+import configs from 'rete-cli/eslint.config.mjs';
+import globals from 'globals'
+
+export default tseslint.config(
+  ...configs,
+  {
+    languageOptions: {
+      globals: {
+        ...globals.browser
+      }
+    }
+  }
+)

eslint.config.mjs

@@ -27,10 +27,10 @@
     "rete-area-plugin": "^2.0.0"
   },
   "devDependencies": {
+    "globals": "^15.9.0",
     "rete": "^2.0.1",
     "rete-area-plugin": "^2.0.0",
-    "rete-cli": "^1.0.2",
-    "typescript": "5.0"
+    "rete-cli": "~2.0.1"
   },
   "dependencies": {
     "@babel/runtime": "^7.21.0"

package-lock.json

@@ -84,21 +84,21 @@ export class ContextMenuPlugin<Schemes extends BaseSchemes> extends Scope<never,
         element.style.top = `${context.data.event.clientY}px`
         element.style.display = ''
 
-        parent.emit({
+        void parent.emit({
           type: 'render',
           data: {
             type: 'contextmenu',
             element,
             searchBar,
             onHide() {
-              parent.emit({ type: 'unmount', data: { element } })
+              void parent.emit({ type: 'unmount', data: { element } })
             },
             items: list
           }
         })
       } else if (context.type === 'pointerdown') {
         if (!context.data.event.composedPath().includes(element)) {
-          parent.emit({ type: 'unmount', data: { element } })
+          void parent.emit({ type: 'unmount', data: { element } })
         }
       }
       return context

package.json

@@ -9,26 +9,29 @@ export function createItem<S extends BSchemes>(
   key: string | number,
   context: { editor: NodeEditor<S>, area: BaseAreaPlugin<S, any> }
 ): Item {
-  const item = {
+  const item: Item = {
     label,
-    key: String(key)
+    key: String(key),
+    handler() {
+      /* noop */
+    }
   }
 
   if (typeof factory === 'function') {
-    return <Item>{
+    return {
       ...item,
       async handler() {
         const node = await factory()
 
         await context.editor.addNode(node)
 
-        context.area.translate(node.id, context.area.area.pointer)
+        void context.area.translate(node.id, context.area.area.pointer)
       }
-    }
+    } satisfies Item
   }
-  return <Item>{
+  return {
     ...item,
-    handler() {/* do nothing */},
+    handler() { /* do nothing */ },
     subitems: factory.map((data, i) => createItem(data, i, context))
-  }
+  } satisfies Item
 }

src/index.ts

@@ -10,13 +10,13 @@ import { BSchemes, ItemDefinition } from './types'
  * Configures nodes/actions items for root and Delete/Clone items for nodes
  * @param nodes List of items
  * @example Presets.classic.setup([
-  ["Math", [
-    ["Number", () => new NumberNode()],
-  ]]
-])
+ *  ["Math", [
+ *    ["Number", () => new NumberNode()],
+ *  ]]
+ *])
  */
 export function setup<Schemes extends BSchemes>(nodes: ItemDefinition<Schemes>[]) {
-  return <Items<Schemes>>(function (context, plugin) {
+  return function (context, plugin) {
     const area = plugin.parentScope<BaseAreaPlugin<Schemes, any>>(BaseAreaPlugin)
     const editor = area.parentScope<NodeEditor<Schemes>>(NodeEditor)
 
@@ -60,16 +60,18 @@ export function setup<Schemes extends BSchemes>(nodes: ItemDefinition<Schemes>[]
 
         await editor.addNode(node)
 
-        area.translate(node.id, area.area.pointer)
+        void area.translate(node.id, area.area.pointer)
       }
     }
 
     return {
       searchBar: false,
       list: [
         deleteItem,
-        ...(cloneItem ? [cloneItem] : [])
+        ...cloneItem
+          ? [cloneItem]
+          : []
       ]
     }
-  })
+  } satisfies Items<Schemes>
 }

src/presets/classic/factory.ts

@@ -1,6 +1,6 @@
 /**
  * Presets that create items for root and node specific context menu.
  * @module
-*/
+ */
 
 export * as classic from './classic'

src/presets/classic/index.ts

@@ -10,12 +10,12 @@ export type Position = { x: number, y: number }
 export type Item = {
   label: string
   key: string
-  handler(): void
+  handler(): void | Promise<void>
   subitems?: Item[]
 }
 
 export type ItemsCollection = {
-  searchBar?: boolean,
+  searchBar?: boolean
   list: Item[]
 }