From b3c957f0bdc5baf3e2b96cf7765480d649037df2 Mon Sep 17 00:00:00 2001 From: Benedikt Bongartz Date: Wed, 25 Feb 2026 11:09:58 +0100 Subject: [PATCH] fix: allow traces.write.otlphttp.endpoint without grpc-listen flag The validation logic incorrectly required --grpc-listen for all traces endpoints. This prevented using --traces.write.otlphttp.endpoint alone, even though OTLP HTTP uses the standard HTTP server (port 8080) and doesn't need gRPC. Signed-off-by: Benedikt Bongartz --- main.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/main.go b/main.go index a7688e23..a11baba1 100644 --- a/main.go +++ b/main.go @@ -1547,12 +1547,12 @@ func parseFlags() (config, error) { } } - if cfg.traces.enabled && cfg.server.grpcListen == "" { - return cfg, fmt.Errorf("-traces.write.endpoint is set to %q but -grpc.listen is not set", cfg.traces.writeOTLPGRPCEndpoint) + if cfg.traces.writeOTLPGRPCEndpoint != "" && cfg.server.grpcListen == "" { + return cfg, fmt.Errorf("--traces.write.endpoint is set to %q but --grpc.listen is not set", cfg.traces.writeOTLPGRPCEndpoint) } - if !cfg.traces.enabled && cfg.server.grpcListen != "" { - return cfg, fmt.Errorf("-traces.write.endpoint is not set but -grpc.listen is set to %q", cfg.server.grpcListen) + if cfg.traces.writeOTLPGRPCEndpoint == "" && cfg.server.grpcListen != "" { + return cfg, fmt.Errorf("--traces.write.endpoint is not set but --grpc.listen is set to %q", cfg.server.grpcListen) } if rawTLSCipherSuites != "" {