fix: container slot picker auto-generation, grid rendering, and part … #26

Workflow file for this run

.github/workflows/backend-quality.yml at de5f3a9

	name: Backend Code Quality

	on:
	push:
	branches: [ main, develop ]
	paths:
	- 'MakerMatrix/*/.py'
	- 'tests/*/.py'
	- 'pyproject.toml'
	- '.github/workflows/backend-quality.yml'
	- 'requirements.txt'
	pull_request:
	branches: [ main, develop ]
	paths:
	- 'MakerMatrix/*/.py'
	- 'tests/*/.py'
	- 'pyproject.toml'
	- '.github/workflows/backend-quality.yml'
	- 'requirements.txt'
	workflow_dispatch:

	jobs:
	# Code Formatting Check
	black-formatting:
	runs-on: ubuntu-latest

	steps:
	- name: Checkout code
	uses: actions/checkout@v4

	- name: Setup Python
	uses: actions/setup-python@v4
	with:
	python-version: '3.11'
	cache: 'pip'

	- name: Install Black
	run: \|
	python -m pip install --upgrade pip
	pip install black

	- name: Check code formatting with Black
	run: \|
	black --check --diff --color MakerMatrix/
	continue-on-error: true # WARN but don't fail (for gradual adoption)

	- name: Show formatting diff
	if: failure()
	run: \|
	echo "❌ Code formatting issues found!"
	echo "Run 'black MakerMatrix/' locally to fix formatting"
	black --diff MakerMatrix/

	# Dead Code Analysis
	dead-code-analysis:
	runs-on: ubuntu-latest

	steps:
	- name: Checkout code
	uses: actions/checkout@v4

	- name: Setup Python
	uses: actions/setup-python@v4
	with:
	python-version: '3.11'
	cache: 'pip'

	- name: Create virtual environment
	run: \|
	python -m venv venv_test
	source venv_test/bin/activate
	pip install --upgrade pip

	- name: Install dependencies
	run: \|
	source venv_test/bin/activate
	pip install -r requirements.txt
	pip install vulture

	- name: Run Vulture dead code analysis
	run: \|
	source venv_test/bin/activate
	vulture MakerMatrix/ --config pyproject.toml --sort-by-size > vulture_report.txt \|\| true
	cat vulture_report.txt

	- name: Check for critical dead code
	run: \|
	source venv_test/bin/activate
	# Fail if vulture finds high-confidence (>95%) unused code outside of tests
	if vulture MakerMatrix/ --config pyproject.toml --min-confidence 95 --exclude MakerMatrix/tests/ \| grep -q "unused"; then
	echo "❌ High-confidence dead code found!"
	vulture MakerMatrix/ --config pyproject.toml --min-confidence 95 --exclude MakerMatrix/tests/
	exit 1
	else
	echo "✅ No critical dead code found"
	fi

	- name: Upload vulture report
	uses: actions/upload-artifact@v4
	if: always()
	with:
	name: vulture-report
	path: vulture_report.txt
	retention-days: 30

	- name: Comment on PR
	uses: actions/github-script@v7
	if: github.event_name == 'pull_request'
	with:
	script: \|
	const fs = require('fs');

	if (fs.existsSync('vulture_report.txt')) {
	const report = fs.readFileSync('vulture_report.txt', 'utf8');
	const lines = report.split('\n').filter(l => l.trim());

	if (lines.length > 0) {
	let comment = '## 🔍 Dead Code Analysis Report\n\n';
	comment += `Found ${lines.length} potential dead code issues:\n\n`;
	comment += '```\n' + lines.slice(0, 20).join('\n') + '\n```\n\n';

	if (lines.length > 20) {
	comment += `\n_Showing first 20 of ${lines.length} issues. See the full report in the artifacts._\n`;
	}

	github.rest.issues.createComment({
	issue_number: context.issue.number,
	owner: context.repo.owner,
	repo: context.repo.repo,
	body: comment
	});
	}
	}

	# Python Linting
	python-lint:
	runs-on: ubuntu-latest

	steps:
	- name: Checkout code
	uses: actions/checkout@v4

	- name: Setup Python
	uses: actions/setup-python@v4
	with:
	python-version: '3.11'
	cache: 'pip'

	- name: Install dependencies
	run: \|
	python -m venv venv_test
	source venv_test/bin/activate
	pip install --upgrade pip
	pip install -r requirements.txt
	pip install pylint flake8

	- name: Run pylint
	run: \|
	source venv_test/bin/activate
	pylint MakerMatrix/ --exit-zero --output-format=text > pylint_report.txt
	cat pylint_report.txt
	continue-on-error: true

	- name: Run flake8
	run: \|
	source venv_test/bin/activate
	flake8 MakerMatrix/ --max-line-length=120 --exclude=venv_test,node_modules --exit-zero
	continue-on-error: true

	- name: Upload lint reports
	uses: actions/upload-artifact@v4
	if: always()
	with:
	name: lint-reports
	path: \|
	pylint_report.txt
	retention-days: 30

	# Type Checking
	type-check:
	runs-on: ubuntu-latest

	steps:
	- name: Checkout code
	uses: actions/checkout@v4

	- name: Setup Python
	uses: actions/setup-python@v4
	with:
	python-version: '3.11'
	cache: 'pip'

	- name: Install dependencies
	run: \|
	python -m venv venv_test
	source venv_test/bin/activate
	pip install --upgrade pip
	pip install -r requirements.txt
	pip install mypy

	- name: Run mypy type checking
	run: \|
	source venv_test/bin/activate
	mypy MakerMatrix/ --ignore-missing-imports --no-strict-optional \|\| true
	continue-on-error: true

	# Security Tests
	security-tests:
	runs-on: ubuntu-latest

	steps:
	- name: Checkout code
	uses: actions/checkout@v4

	- name: Setup Python
	uses: actions/setup-python@v4
	with:
	python-version: '3.11'
	cache: 'pip'

	- name: Create virtual environment
	run: \|
	python -m venv venv_test
	source venv_test/bin/activate
	pip install --upgrade pip

	- name: Install dependencies
	run: \|
	source venv_test/bin/activate
	pip install -r requirements.txt
	pip install pytest pytest-asyncio

	- name: Run security tests
	run: \|
	source venv_test/bin/activate
	pytest tests/test_security_fixes.py -v --tb=short --junit-xml=security-test-results.xml
	continue-on-error: false

	- name: Run critical security tests
	run: \|
	source venv_test/bin/activate
	# Run tests marked as critical - these must pass
	pytest tests/test_security_fixes.py -v -m critical --tb=short \|\| echo "⚠️ Critical security tests found issues"

	- name: Upload security test results
	uses: actions/upload-artifact@v4
	if: always()
	with:
	name: security-test-results
	path: security-test-results.xml
	retention-days: 30

	- name: Comment on PR with security results
	uses: actions/github-script@v7
	if: github.event_name == 'pull_request' && failure()
	with:
	script: \|
	const comment = `## 🔒 Security Tests Failed

	One or more security tests have failed. Please review the security test results in the artifacts.

	Action Required:
	- Review the test failures
	- Fix any security vulnerabilities
	- Re-run the tests

	See the full report in the workflow artifacts.`;

	github.rest.issues.createComment({
	issue_number: context.issue.number,
	owner: context.repo.owner,
	repo: context.repo.repo,
	body: comment
	});

	# Integration Tests - Backup/Restore
	integration-tests:
	runs-on: ubuntu-latest

	steps:
	- name: Checkout code
	uses: actions/checkout@v4

	- name: Setup Python
	uses: actions/setup-python@v4
	with:
	python-version: '3.11'
	cache: 'pip'

	- name: Create virtual environment
	run: \|
	python -m venv venv_test
	source venv_test/bin/activate
	pip install --upgrade pip

	- name: Install dependencies
	run: \|
	source venv_test/bin/activate
	pip install -r requirements.txt
	pip install pytest pytest-asyncio

	- name: Run backup/restore integration tests
	run: \|
	source venv_test/bin/activate
	pytest tests/test_backup_restore_integration.py -v --tb=short --junit-xml=integration-test-results.xml
	timeout-minutes: 10
	continue-on-error: false

	- name: Upload test databases on failure
	uses: actions/upload-artifact@v4
	if: failure()
	with:
	name: failed-test-databases
	path: /tmp/makermatrix_test_dbs/
	retention-days: 7

	- name: Upload integration test results
	uses: actions/upload-artifact@v4
	if: always()
	with:
	name: integration-test-results
	path: integration-test-results.xml
	retention-days: 30

	- name: Comment on PR with integration test results
	uses: actions/github-script@v7
	if: github.event_name == 'pull_request' && failure()
	with:
	script: \|
	const comment = `## 🔧 Integration Tests Failed

	Backup/restore integration tests have failed. These tests verify:
	- Database backup creation
	- Backup file integrity
	- Restore operations
	- Data integrity after restore

	Action Required:
	- Review the test failures in the artifacts
	- Check for database schema changes
	- Verify backup/restore logic
	- Re-run the tests

	See the full report in the workflow artifacts.`;

	github.rest.issues.createComment({
	issue_number: context.issue.number,
	owner: context.repo.owner,
	repo: context.repo.repo,
	body: comment
	});

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: container slot picker auto-generation, grid rendering, and part … #26

Workflow file

fix: container slot picker auto-generation, grid rendering, and part … #26

Uh oh!

Workflow file for this run