refactor: remove rollback actions and align command validation tests

Author: risunCode

app/src/main/java/com/appcontrolx/ui/screens/settings/SettingsScreen.kt

@@ -20,7 +20,6 @@ import androidx.hilt.navigation.compose.hiltViewModel
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import com.appcontrolx.data.ThemeMode
 import com.appcontrolx.model.ActionHistoryItem
-import com.appcontrolx.model.AppAction
 import com.appcontrolx.model.ExecutionMode
 
 @OptIn(ExperimentalMaterial3Api::class)
@@ -430,7 +429,6 @@ fun SettingsScreen(
     if (showActionHistoryDialog) {
         ActionHistoryDialog(
             history = actionHistory,
-            onRollback = { viewModel.rollbackAction(it) },
             onClear = { viewModel.clearHistory() },
             onDismiss = { showActionHistoryDialog = false }
         )
@@ -674,7 +672,6 @@ private fun ThemeOption(
 @Composable
 private fun ActionHistoryDialog(
     history: List<ActionHistoryItem>,
-    onRollback: (ActionHistoryItem) -> Unit,
     onClear: () -> Unit,
     onDismiss: () -> Unit
 ) {
@@ -736,10 +733,7 @@ private fun ActionHistoryDialog(
                     verticalArrangement = Arrangement.spacedBy(8.dp)
                 ) {
                     items(history, key = { it.timestamp }) { item ->
-                        ActionHistoryItem(
-                            item = item,
-                            onRollback = { onRollback(item) }
-                        )
+                        ActionHistoryItem(item = item)
                     }
                 }
             }
@@ -749,8 +743,7 @@ private fun ActionHistoryDialog(
 
 @Composable
 private fun ActionHistoryItem(
-    item: ActionHistoryItem,
-    onRollback: () -> Unit
+    item: ActionHistoryItem
 ) {
     Surface(
         modifier = Modifier.fillMaxWidth(),

app/src/main/java/com/appcontrolx/ui/screens/settings/SettingsViewModel.kt

@@ -8,9 +8,7 @@ import com.appcontrolx.core.ShellManager
 import com.appcontrolx.data.ActionHistoryStore
 import com.appcontrolx.data.ThemeMode
 import com.appcontrolx.data.UserPreferences
-import com.appcontrolx.domain.AppManager
 import com.appcontrolx.model.ActionHistoryItem
-import com.appcontrolx.model.AppAction
 import com.appcontrolx.model.ExecutionMode
 import dagger.hilt.android.lifecycle.HiltViewModel
 import dagger.hilt.android.qualifiers.ApplicationContext
@@ -35,7 +33,6 @@ class SettingsViewModel @Inject constructor(
     @ApplicationContext private val context: Context,
     private val userPreferences: UserPreferences,
     private val shellManager: ShellManager,
-    private val appManager: AppManager,
     private val actionHistoryStore: ActionHistoryStore
 ) : ViewModel() {
 
@@ -103,17 +100,6 @@ class SettingsViewModel @Inject constructor(
         }
     }
 
-    fun rollbackAction(item: ActionHistoryItem) {
-        viewModelScope.launch {
-            val rollbackAction = when (item.action) {
-                AppAction.FREEZE -> AppAction.UNFREEZE
-                AppAction.UNFREEZE -> AppAction.FREEZE
-                else -> return@launch
-            }
-            appManager.executeAction(item.packageName, rollbackAction)
-        }
-    }
-
     fun clearHistory() {
         viewModelScope.launch {
             actionHistoryStore.clearHistory()

app/src/test/java/com/appcontrolx/core/CommandValidatorTest.kt

@@ -0,0 +1,60 @@
+package com.appcontrolx.core
+
+import org.junit.Assert.assertTrue
+import org.junit.Test
+
+class CommandValidatorTest {
+
+    @Test
+    fun allowsSupportedCommandFamilies() {
+        val commands = listOf(
+            "pm disable-user --user 0 com.example.app",
+            "am force-stop com.example.app",
+            "appops set com.example.app RUN_IN_BACKGROUND ignore",
+            "cmd appops query-op RUN_IN_BACKGROUND ignore",
+            "dumpsys activity processes"
+        )
+
+        commands.forEach { command ->
+            val result = CommandValidator.validate(command)
+            assertTrue("Expected command to be allowed: $command", result.isSuccess)
+        }
+    }
+
+    @Test
+    fun rejectsDisallowedCommandPrefixes() {
+        val commands = listOf(
+            "sh -c pm clear com.example.app",
+            "rm -rf /",
+            "ls /data"
+        )
+
+        commands.forEach { command ->
+            val result = CommandValidator.validate(command)
+            assertTrue("Expected command to be rejected: $command", result.isFailure)
+        }
+    }
+
+    @Test
+    fun rejectsDangerousShellPatterns() {
+        val commands = listOf(
+            "pm clear com.example.app && pm enable com.example.app",
+            "pm clear com.example.app$(id)",
+            "pm clear com.example.app > /sdcard/out.txt"
+        )
+
+        commands.forEach { command ->
+            val result = CommandValidator.validate(command)
+            assertTrue("Expected dangerous command to be rejected: $command", result.isFailure)
+        }
+    }
+
+    @Test
+    fun rejectsBlankAndInvalidCommands() {
+        val blank = CommandValidator.validate("   ")
+        val invalidStructure = CommandValidator.validate("pm clear")
+
+        assertTrue("Expected blank command to be rejected", blank.isFailure)
+        assertTrue("Expected invalid command structure to be rejected", invalidStructure.isFailure)
+    }
+}