Select calls cannot be made in parallel

[richorama]

The results array is global to the module. if a client makes two simultaneous selects, one select return with also include results from the other select.

I suggest scoping results to a function.

[tracend]

A good point definitely

[rjrodger]

yikes, sorry about that guys. I suck at coding.

richorama adding you as a contrib, see https://github.com/rvagg/node-levelup/blob/master/CONTRIBUTING.md

[Reggino]

Argh... learned this the hard way... ( I just sent an e-mail to a few hundred people based on incorrect and mixed up query results :-( ) . Maybe we should point out in the main readme.md this code is to be considered highly beta and not ready for production use?

[tracend]

Personally I include all requests in an async series, so I don't have that problem.

Having said that, if parallel processing is a common use-case I think it can be reasonably easy to support with a queue system that keeps tabs of different requests.

More than any specific feature, I feel the library will benefit by splitting it to more than one file, so there's more abstraction and easier to extend.

[Reggino]

Sorry for my previous crude post... it was just not my day.. :-)

I don't think queuing isn't necessary here: aws-sdk is perfectly able to perform simultaneous queries. It should just be implemented properly (and some tests should be added to prevent regression)

The problem is probably related to the globally scoped var results here https://github.com/rjrodger/simpledb/blob/master/lib/simpledb.js#L124 . As suggested by @richorama that should be scoped to prevent these kind of issues. I agree with @tracend that restructuring the code will probably fix that along the way.