fix: use trim_mode "-" with explicit -%> for ERB control structures

The ERB renderer uses trim_mode: "-" which requires explicit -%> syntax to
suppress newlines from control structure tags. Updated all test templates to:

- Add -%> to <% if ... %> tags to suppress trailing newlines
- Add -%> to <% if_p(...) do |var| %> tags for conditional helpers
- Add -%> to <% .each do |var| %> tags for iteration  
- Add -%> to <% .each_with_index do |var, idx| %> tags
- Add -%> to <% .map {...}.each do |var| %> tags for chained operations
- Add -%> to <% end %> tags to close control structures cleanly

This approach maintains compatibility with the standard BOSH ERB trim_mode
while ensuring test expectations match actual rendered output.

Fixes: rkoster/rubionic-workspace#229

Author: rubionic

templatescompiler/erbrenderer/erb_renderer.rb

@@ -193,7 +193,7 @@ def initialize(json_context_path)
   end
 
   def render(src_path, dst_path)
-    erb = ERB.new(File.read(src_path), trim_mode: ">")
+    erb = ERB.new(File.read(src_path), trim_mode: "-")
     erb.filename = src_path
 
     context_hash = JSON.load(File.read(@json_context_path))

templatescompiler/erbrenderer/erb_renderer_test.go

@@ -230,9 +230,9 @@ no_default: default_value`
 				})
 
 				It("executes block when property exists", func() {
-					erbTemplateContent = `<% if_p('feature_config.host') do |host| %>
+					erbTemplateContent = `<% if_p('feature_config.host') do |host| -%>
 host_configured: <%= host %>
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 host_configured: example.com
 `
@@ -249,9 +249,9 @@ host_configured: example.com
 				})
 
 				It("supports multiple properties in if_p", func() {
-					erbTemplateContent = `<% if_p('feature_config.host', 'feature_config.port') do |host, port| %>
+					erbTemplateContent = `<% if_p('feature_config.host', 'feature_config.port') do |host, port| -%>
 config: <%= host %>:<%= port %>
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 config: example.com:8080
 `
@@ -269,9 +269,9 @@ config: example.com:8080
 
 				It("skips block when property is missing", func() {
 					erbTemplateContent = `before
-<% if_p('completely_missing_prop') do |host| %>
+<% if_p('completely_missing_prop') do |host| -%>
 should_not_appear: <%= host %>
-<% end %>
+<% end -%>
 after`
 					expectedTemplateContents = `before
 
@@ -315,9 +315,9 @@ after`
 				})
 
 				It("iterates over array and accesses hash elements", func() {
-					erbTemplateContent = `<% p('users').each do |user| %>
+					erbTemplateContent = `<% p('users').each do |user| -%>
 user: <%= user['name'] %> pass: <%= user['password'] %>
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 user: alice pass: secret1
 
@@ -525,9 +525,9 @@ debug is disabled
 				})
 
 				It("transforms array elements using map with block", func() {
-					erbTemplateContent = `<% p('servers').map { |s| s['host'] }.each do |host| %>
+					erbTemplateContent = `<% p('servers').map { |s| s['host'] }.each do |host| -%>
 host: <%= host %>
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 host: 10.0.0.1
 
@@ -693,9 +693,9 @@ host: 10.0.0.2
 				})
 
 				It("iterates with index access", func() {
-					erbTemplateContent = `<% p('routes').each_with_index do |route, index| %>
+					erbTemplateContent = `<% p('routes').each_with_index do |route, index| -%>
 route_<%= index %>: <%= route['uri'] %>
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 route_0: api.example.com
 
@@ -754,9 +754,9 @@ route_1: www.example.com
 				})
 
 				It("checks for hash key membership", func() {
-					erbTemplateContent = `<% if p('config').key?('optional_key') %>
+					erbTemplateContent = `<% if p('config').key?('optional_key') -%>
 has_key: true
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 has_key: true
 `
@@ -794,9 +794,9 @@ has_key: true
 				})
 
 				It("checks string prefix with start_with?", func() {
-					erbTemplateContent = `<% if p('api_url').start_with?('https') %>
+					erbTemplateContent = `<% if p('api_url').start_with?('https') -%>
 secure: true
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 secure: true
 `
@@ -813,9 +813,9 @@ secure: true
 				})
 
 				It("checks for empty strings", func() {
-					erbTemplateContent = `<% if p('cert') == "" %>
+					erbTemplateContent = `<% if p('cert') == "" -%>
 no_cert: true
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 no_cert: true
 `
@@ -955,12 +955,12 @@ provider_name: thales`
 				})
 
 				It("checks if any element matches condition", func() {
-					erbTemplateContent = `<% if p('providers').any? { |p| p['type'] == 'hsm' } %>
+					erbTemplateContent = `<% if p('providers').any? { |p| p['type'] == 'hsm' } -%>
 using_hsm: true
-<% end %>
-<% if !p('empty_list').any? %>
+<% end -%>
+<% if !p('empty_list').any? -%>
 list_empty: true
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 using_hsm: true
 list_empty: true
@@ -1001,18 +1001,18 @@ list_empty: true
 				})
 
 				It("checks for empty strings and arrays", func() {
-					erbTemplateContent = `<% if p('optional_cert').empty? %>
+					erbTemplateContent = `<% if p('optional_cert').empty? -%>
 no_cert: true
-<% end %>
-<% if !p('required_key').empty? %>
+<% end -%>
+<% if !p('required_key').empty? -%>
 has_key: true
-<% end %>
-<% if p('empty_array').empty? %>
+<% end -%>
+<% if p('empty_array').empty? -%>
 array_empty: true
-<% end %>
-<% if !p('filled_array').empty? %>
+<% end -%>
+<% if !p('filled_array').empty? -%>
 array_filled: true
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 no_cert: true
 has_key: true
@@ -1053,12 +1053,12 @@ array_filled: true
 				})
 
 				It("checks array membership", func() {
-					erbTemplateContent = `<% if p('valid_modes').include?(p('selected_mode')) %>
+					erbTemplateContent = `<% if p('valid_modes').include?(p('selected_mode')) -%>
 valid_selection: true
-<% end %>
-<% if p('tls_modes').include?('enabled') %>
+<% end -%>
+<% if p('tls_modes').include?('enabled') -%>
 supports_tls: true
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 valid_selection: true
 supports_tls: true
@@ -1212,14 +1212,14 @@ retries: 3`
 				})
 
 				It("finds substring positions with index", func() {
-					erbTemplateContent = `<% if p('cert_with_newlines').index("\n").nil? %>
+					erbTemplateContent = `<% if p('cert_with_newlines').index("\n").nil? -%>
 no_real_newline: true
 <% else %>
 has_real_newline: true
-<% end %>
-<% if p('cert_without_newlines').index("\n").nil? %>
+<% end -%>
+<% if p('cert_without_newlines').index("\n").nil? -%>
 no_escaped_newline: true
-<% end %>`
+<% end -%>`
 					expectedTemplateContents = `
 has_real_newline: true