From 2e2f4ee059e58333dde505b7ac26d1f4f1a79465 Mon Sep 17 00:00:00 2001
From: bipinparajuli <bipinprjl@gmail.com>
Date: Thu, 24 Oct 2024 17:54:58 +0545
Subject: [PATCH 1/2] fix:remove dto from user list

---
 libs/user/src/lib/users/users.controller.ts | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/libs/user/src/lib/users/users.controller.ts b/libs/user/src/lib/users/users.controller.ts
index cd014f8..7246ada 100755
--- a/libs/user/src/lib/users/users.controller.ts
+++ b/libs/user/src/lib/users/users.controller.ts
@@ -12,11 +12,7 @@ import {
 } from '@nestjs/common';
 import { ApiBearerAuth, ApiBody, ApiTags } from '@nestjs/swagger';
 import { ApiUuidParam, RequestDetails } from '@rumsan/extensions/decorators';
-import {
-  CreateUserDto,
-  ListUserDto,
-  UpdateUserDto,
-} from '@rumsan/extensions/dtos';
+import { CreateUserDto, UpdateUserDto } from '@rumsan/extensions/dtos';
 import { ERRORS } from '@rumsan/extensions/exceptions';
 import { Request } from '@rumsan/sdk/types';
 import { UUID } from 'crypto';
@@ -37,7 +33,8 @@ export class UsersController {
 
   @CheckAbilities({ actions: ACTIONS.READ, subject: SUBJECTS.USER })
   @Get('')
-  list(@Query() dto: ListUserDto) {
+  list(@Query() dto: any) {
+    //TODO ListUserDto
     return this.userService.list(dto);
   }
 

From 66c1f48a1f635a26ccc44e27f0ce7b2561f5ffc7 Mon Sep 17 00:00:00 2001
From: bipinparajuli <bipinprjl@gmail.com>
Date: Fri, 25 Oct 2024 10:39:22 +0545
Subject: [PATCH 2/2] fix:user list dto

---
 libs/extensions/src/dtos/shared/pagination.dto.ts | 10 +++++++---
 libs/user/src/lib/users/users.controller.ts       |  9 ++++++---
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/libs/extensions/src/dtos/shared/pagination.dto.ts b/libs/extensions/src/dtos/shared/pagination.dto.ts
index 6780e3d..38ce764 100644
--- a/libs/extensions/src/dtos/shared/pagination.dto.ts
+++ b/libs/extensions/src/dtos/shared/pagination.dto.ts
@@ -1,22 +1,26 @@
 import { ApiProperty } from '@nestjs/swagger';
 import { Type } from 'class-transformer';
-import { IsIn, IsOptional, IsString } from 'class-validator';
+import { IsIn, IsNumber, IsOptional, IsString } from 'class-validator';
 
 export class PaginationDto {
   @ApiProperty({
     example: 1,
-    description: 'page number',
+    description: 'Page number',
     required: false,
   })
+  @IsOptional()
   @Type(() => Number)
+  @IsNumber()
   page?: number = 1;
 
   @ApiProperty({
     example: 10,
-    description: 'number of items per page',
+    description: 'Number of items per page',
     required: false,
   })
+  @IsOptional()
   @Type(() => Number)
+  @IsNumber()
   perPage?: number = 20;
 
   @ApiProperty({
diff --git a/libs/user/src/lib/users/users.controller.ts b/libs/user/src/lib/users/users.controller.ts
index 7246ada..cd014f8 100755
--- a/libs/user/src/lib/users/users.controller.ts
+++ b/libs/user/src/lib/users/users.controller.ts
@@ -12,7 +12,11 @@ import {
 } from '@nestjs/common';
 import { ApiBearerAuth, ApiBody, ApiTags } from '@nestjs/swagger';
 import { ApiUuidParam, RequestDetails } from '@rumsan/extensions/decorators';
-import { CreateUserDto, UpdateUserDto } from '@rumsan/extensions/dtos';
+import {
+  CreateUserDto,
+  ListUserDto,
+  UpdateUserDto,
+} from '@rumsan/extensions/dtos';
 import { ERRORS } from '@rumsan/extensions/exceptions';
 import { Request } from '@rumsan/sdk/types';
 import { UUID } from 'crypto';
@@ -33,8 +37,7 @@ export class UsersController {
 
   @CheckAbilities({ actions: ACTIONS.READ, subject: SUBJECTS.USER })
   @Get('')
-  list(@Query() dto: any) {
-    //TODO ListUserDto
+  list(@Query() dto: ListUserDto) {
     return this.userService.list(dto);
   }