Add Grove PodCliqueSet (grove.io/v1alpha1) Karta example#66
Add Grove PodCliqueSet (grove.io/v1alpha1) Karta example#66shmuel-runai wants to merge 1 commit into
Conversation
Reference Karta definition for the Grove PodCliqueSet CRD covering status mappings, clique/scaling-group child components, additional child kinds, and gang-scheduling optimization instructions. Closes #65
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughA new documentation example YAML file defines a complete Karta workload specification for Grove PodCliqueSet, including replica-based status conditions, child component definitions with scaling formulas, additional resource kinds, and gang-scheduling pod group membership rules keyed by labels. ChangesGrove PodCliqueSet Karta Example
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ronlv10
left a comment
There was a problem hiding this comment.
Overall looks good , left a few comments
| expectedResult: "true" | ||
| initializing: | ||
| - byExpression: | ||
| expression: '(.spec.replicas // 0) > 0 and (.status.availableReplicas // 0) < (.spec.replicas // 0)' |
There was a problem hiding this comment.
could it be that .spec.replicas is missing or 0 ? what should the phase in this case ?
| schedulerNamePath: .spec.template.cliques[].spec.podSpec.schedulerName | ||
| labelsPath: .spec.template.cliques[].labels | ||
| annotationsPath: .spec.template.cliques[].annotations | ||
| containersPath: .spec.template.cliques[].spec.podSpec.containers |
There was a problem hiding this comment.
seems like you could use
podSpecPath: .spec.template.cliques[].spec.podSpec
but the issue is the path to metadata that missing ? wondering maybe we could add Fragmented metadata - would it help you to set the path to pod spec and just paths to annotations and labelsr ? currenly we enforce either podSpecPath , podTemplateSpecPath or fragmentedPodSpecDefinition but we could add fragmentedMetadataDefinition (hope I want clear)
Closes #65
Reference Karta definition for the Grove PodCliqueSet CRD covering
status mappings, clique/scaling-group child components, additional
child kinds, and gang-scheduling optimization instructions.
Summary by CodeRabbit
Release Notes