Release tracking v0.3.0

[nyonson]

The plan is for the v0.3.x branch to be an LTS release tied to bitcoin v0.32.* and miniscript v12.*.*. There will not be development on this branch for things like v2 and silent payments.

• All changes in bitcoin v0.32.0 to v0.32.8 (don't worry about 0.33.0-beta stuff) have made it over to rust-psbt.
• All changes in miniscript v12.2.0 to v12.3.5 have made it over to rust-psbt.

Once v0.3.0 has been stamped, we can start working on the almost certainly larger effort for v0.4.0-beta. This is where we will get rust-psbt update the latest in both bitcoin and miniscript which should allow us to then remove the psbt modules from those packages.

[nyonson]

@nymius and @tcharding does this make sense? I think v12.2.0 to v12.3.5 is the correct window for miniscript right?

[nymius]

It does for me.

[tcharding]

Got it! Cheers man.

[nyonson]

It looks like the miniscript bump is straight-forward since none of the copied code has been modified up to v12.3.5. src/v0/miniscript/util.rs and src/v2/miniscript/mod.rs compared to util on the 12.x branch. rust-psbt also has a src/miniscript.rs file which contains some copied code, but the module is not declared in src/lib.rs, maybe some dead code?

EDIT: This fix looks nice, but in 13.0: rust-bitcoin/rust-miniscript#858

[nyonson]

Been messing with some git-foo to come up with the simplest command to find relevant PRs for changes to the copied code sections.

> git log --oneline --show-pulls bitcoin-0.32.0..bitcoin-0.32.8 -- bitcoin/src/psbt/ 
6993c6f7 Merge rust-bitcoin/rust-bitcoin#5282: Fix all the lint warnings on 0.32.x branch
fc916808 Clippy allow large error
2044697c Merge rust-bitcoin/rust-bitcoin#4443: backport: Add XOnlyPublicKey support for PSBT key retrieval and improve Taproot signing
f4fac15e Merge rust-bitcoin/rust-bitcoin#4450: backport: Add methods to retrieve inner types
c67adcd6 backport: Add methods to retrieve inner types
95eb2556 Add XOnlyPublicKey support for PSBT key retrieval and improve Taproot signing
2858b6cf Support GetKey where the Xpriv is a direct child of the looked up KeySource
d005ddd5 Refactor GetKey for sets to internally use Xpriv::get_key()
b75b2e36 Fix GetKey for sets to properly compare the fingerprint
b5e9fc45 Merge rust-bitcoin/rust-bitcoin#3173: [0.32] Bound decode methods on `Read`, rather than `BufRead`
f47e54bc Merge rust-bitcoin/rust-bitcoin#3382: Clear all lint errors and warnings
7965e725 Fix rustdoc lint warnings
65f527ba Merge rust-bitcoin/rust-bitcoin#3266: fix: re-implement Psbt (de)serialization from/to readers/writers
d5c79fd9 fix: re-implement (de)serialization from/to readers/writers
79df48e7 Bound decode methods on `Read`, rather than `BufRead`

• #5282
• Backport #4443
• #4450
• Backport #3173
• #3382
• Backport #3266

Of these, I believe only the bolded three touch the copied code in a way which isn't fmt/clippy enforceable in rust-psbt.

[tcharding]

Nice work. I tried a different approach so we'd find different things. I diff'd each file in v0/ against 0.32.x branch psbt module. I know I said we couldn't do this but we can. I must have been high when I said that.

• Missing arbitrary stuff.

We should be careful in any docs because this is currently not exactly what is in 0.32.8. Here we additionally have:

• bip32_derivation is bitcoin::PublicKey here but secp key over on 0.32.x.
• Logic around Error::ExcludedKey (error when deserializing if v2 fields found).

Miniscript looks ok to me using same diff technique.

[nyonson]

Hm, curious when the arbitrary stuff showed up, maybe post-0.32.8 tag? In any case, we don't have arbitrary support in rust-psbt at the moment, so I don't think a blocker to ship 0.3.0.

Other two diffs make sense to me, I think OK given the different structure here. But I can take a pass at any docs for them.

[apoelstra]

The arbitrary stuff showed up in rust-bitcoin/rust-bitcoin#5085

As you can see, it was a very long slog by Yancy, where I'd be avoiding the PR since it was 12 commits long and messed with lockfiles, so every week or two or three I'd post a drive-by comment to the effect of "please fix the crate versions", and we had several iterations of it.

So on the one hand, yes, it was very recent and definitely post 0.32.8 (though we did try to get it into 0.32.8, and I think into 0.32.7), but it's also pretty old.

[nyonson]

Ah, thanks. Looking at that PR, only the Key and ProprietaryKey types are effected in the copied code. Would have to add the arbitrary dependency too. Not a ton of work to do, but not sure the value?

[apoelstra]

The value is that it might help downstream consumers write fuzztests. I think that rust-miniscript would benefit, though I have no short-term plans to take advantage of the new impls.

[tcharding]

Better release huh: rust-bitcoin/rust-bitcoin#5900

[nymius]

It looks like the miniscript bump is straight-forward since none of the copied code has been modified up to v12.3.5 ...

Where is the v12.3.5 tag? Just found it: release-12.x, no tag for it.