-
Notifications
You must be signed in to change notification settings - Fork 2.9k
MSVC examples cannot be exported with out-dir #7493
Copy link
Copy link
Open
Labels
C-bugCategory: bugCategory: bugE-mediumExperience: MediumExperience: MediumO-windowsOS: WindowsOS: WindowsS-needs-mentorStatus: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.Z-out-dirNightly: --out-dirNightly: --out-dir
Metadata
Metadata
Assignees
Labels
C-bugCategory: bugCategory: bugE-mediumExperience: MediumExperience: MediumO-windowsOS: WindowsOS: WindowsS-needs-mentorStatus: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.Z-out-dirNightly: --out-dirNightly: --out-dir
Type
Fields
Give feedbackNo fields configured for issues without a type.
If a project has an example binary, normally
--out-dirwill export those examples to the output directory. However, as of #7400, examples are no longer exported for MSVC targets.This is because the metadata hash has been removed from the filename. The out-dir linking code relies on the hardlink field to know which files to link. Since the example no longer is hard linked, it is no longer exported.
I think somehow
calc_outputs_rustcshould use a different mechanism to determine which files to export.This is relevant to the
collision_exporttest.