auto-import macro fails when exclamation mark is present

[spookyvision]

#20898 was not fixed properly: the bug is still present with error! from e.g. tracing::error, although warn! now works. I'd reopen but lack the permission to do so.

[ChayimFriedman2]

This is fixed, just checked. What is your rust-analyzer version? Can you try with latest prerelease?

[spookyvision]

huh, strange - both release version 0.3.2896-standalone and pre-release 0.4.2911-standalone break as described for me.
any log/trace I can provide for further investigation?

BTW, I have a hunch it has something to do with ambiguity:

• trace! works
• debug! does not - and without a !, a completion for tracing::field::debug is offered
• info! works
• warn! works
• error! does not - and without a !, completions for core::error and std::error are offered

[ChayimFriedman2]

Can you publish a full reproduction project?

[ChayimFriedman2]

And your full rust-analyzer configuration.

[spookyvision]

sure (is there a way to export the effective ra-config?) - before I do so though: are you following my repro exactly? the exclamation mark must be typed for the bug to occur - just using error and then selecting tracing::error! is not sufficient

[spookyvision]

rep(r)o: https://github.com/spookyvision/ra-22442

[ChayimFriedman2]

Now I see; I was typing error with ! preexsiting after, which indeed works. You meant to type the full error!, which is... weird? Not useful IMO? But, probably still a bug.

[ChayimFriedman2]

Do note it still suggests the item but does not autoimport when selecting it, which is... even more weird? I suspect some editor involvement, since if I close the completion list then trigger it manually after the ! it no longer appears.

[ChayimFriedman2]

Okay, I realized what happen, as I suspect this is editor inertia. We do not suggest the flyimport completion after the !, as you can see if you close the completion list and forcibly reopen it. But after typing ! with an existing completion list, the editor keeps it for some reason, and asks us to resolve the stale flyimport item, which we fail to do. The text is inserted since the editor is responsible to that, and the import is discarded since r-a is responsible for that. I'm not entirely sure why warn!() is different but I'm pretty sure this difference has to do with the editor and not r-a.

I'm not sure we can fix this; we need to make the editor re-request completion after !, which might be possible with LSP but I don't know enough to be sure. There is the orthogonal thing that we can (should?) still suggest flyimport after !, but that won't fix this bug.

[spookyvision]

that does not (I think) explain that the bug only seems to occur when there is ambiguity though 🤔 (see my previous bullet list about which macros work - as in: causing a subsequent import after completion - and which ones don't)

anyway, to me it is useful to type error! and then selecting the suggested import, because that already narrows it down to which action/completion I want, without having to do additional cursor navigation.

to be clear, I don't want to complete error! to error! - that would indeed be pointless. I want to cause the auto-import action with a minimal amount of keystrokes, which typically is error!<RET> as opposed to error⬇️⬇️⬇️⬇️⬇️⬇️<RET>

[spookyvision]

ok, it's not ambiguity that triggers the bug, here's something interesting:
when I type error, then cursor-down in the popup list until tracing:error is highlighted, then type ! followed by RET, the import is executed correctly.
This matches what happens in the unambiguous cases: e.g. with info, tracing::info is highlighted before I type !<RET>.

[spookyvision]

screenshots to illustrate the previous comment:

[ChayimFriedman2]

FWIW you can trigger the autoimport assist after you typed ! (Ctrl+Space Enter Enter).

I can see clearly in the logs that VSCode sends the completion resolve request before Enter is pressed, after the item is selected. And it doesn't re-request completion after pressing !. Therefore as I said this is a client issue, and I'm not interested in investigating it more.