Fix the example code in README.md by applying the following compiler …#780
Closed
NAThompson wants to merge 1 commit intorwf2:masterfrom
NAThompson:master
Closed
Fix the example code in README.md by applying the following compiler …#780NAThompson wants to merge 1 commit intorwf2:masterfrom NAThompson:master
NAThompson wants to merge 1 commit intorwf2:masterfrom
NAThompson:master
Conversation
…suggestion:
error[E0658]: procedural macros cannot be expanded to expressions (see issue #38356)
--> src/main.rs:12:38
|
12 | rocket::ignite().mount("/hello", routes![hello]).launch();
| ^^^^^^^^^^^^^^
|
= help: add #![feature(proc_macro_non_items)] to the crate attributes to enable
Author
|
This appears to only show up on the very latest $ rustc --version
rustc 1.31.0-nightly (fc403ad98 2018-09-30)and a few days ago, this was not a compile error. |
Member
|
It's not rustc that's changed, it's Rocket; we're now using procedural macros for more things than before, requiring different feature gates, and we haven't updated the README or guide docs appropriately. There's a final major change I'm working on now that will fix the README as well, but I'm waiting on rust-lang/rust#52121 to land, which will change the feature gates yet again. |
Author
|
Ok, cools, looks like that PR will render this one irrelevant, so this is a non-issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…suggestion:
error[E0658]: procedural macros cannot be expanded to expressions (see issue #38356)
--> src/main.rs:12:38
|
12 | rocket::ignite().mount("/hello", routes![hello]).launch();
| ^^^^^^^^^^^^^^
|
= help: add #![feature(proc_macro_non_items)] to the crate attributes to enable