Skip to content

Commit bd609f9

Browse files
committed
ci: pass BUILD_NUMBER to extension builds
Every workflow that builds and uploads the extension now passes github.run_number as BUILD_NUMBER. Snapshot builds also set SNAPSHOT=true for version_name labeling. Direct node build.mjs calls updated with --experimental-strip-types to support the .ts import in build.mjs.
1 parent 1e20369 commit bd609f9

2 files changed

Lines changed: 19 additions & 4 deletions

File tree

.github/workflows/publish-extension.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ jobs:
2121

2222
- name: Build all packages
2323
run: pnpm build
24+
env:
25+
BUILD_NUMBER: ${{ github.run_number }}
2426

2527
- name: Zip extension
2628
working-directory: packages/devtools-extension
@@ -52,10 +54,14 @@ jobs:
5254

5355
- name: Build all packages
5456
run: pnpm build
57+
env:
58+
BUILD_NUMBER: ${{ github.run_number }}
5559

5660
- name: Build Firefox extension
5761
working-directory: packages/devtools-extension
58-
run: node build.mjs --target=firefox
62+
run: node --experimental-strip-types build.mjs --target=firefox
63+
env:
64+
BUILD_NUMBER: ${{ github.run_number }}
5965

6066
- name: Zip extension
6167
working-directory: packages/devtools-extension

.github/workflows/release.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ jobs:
3838

3939
- name: Build
4040
run: pnpm build
41+
env:
42+
BUILD_NUMBER: ${{ github.run_number }}
43+
SNAPSHOT: 'true'
4144

4245
- name: Publish npm snapshots
4346
run: pnpm changeset publish --tag snapshot
@@ -64,7 +67,10 @@ jobs:
6467
- name: Build Firefox extension
6568
if: inputs.extension
6669
working-directory: packages/devtools-extension
67-
run: node build.mjs --target=firefox
70+
run: node --experimental-strip-types build.mjs --target=firefox
71+
env:
72+
BUILD_NUMBER: ${{ github.run_number }}
73+
SNAPSHOT: 'true'
6874

6975
- name: Zip Firefox extension
7076
if: inputs.extension
@@ -106,14 +112,17 @@ jobs:
106112

107113
- name: Build
108114
run: pnpm build
115+
env:
116+
BUILD_NUMBER: ${{ github.run_number }}
109117

110118
- name: Create release PR or publish
111119
uses: changesets/action@63a615b9cd06ba9a3e6d13796c7fbcb080a60a0b # v1.8.0
112120
with:
113121
publish: pnpm release
114122
version: pnpm run version
115-
title: "chore: version packages"
116-
commit: "chore: version packages"
123+
title: 'chore: version packages'
124+
commit: 'chore: version packages'
117125
env:
118126
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
119127
NPM_CONFIG_PROVENANCE: true
128+
BUILD_NUMBER: ${{ github.run_number }}

0 commit comments

Comments
 (0)